Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 8b7ce08

Browse files
committed
Remove redundant checks in get_success etc
1 parent d4a92c9 commit 8b7ce08

File tree

1 file changed

+5
-16
lines changed

1 file changed

+5
-16
lines changed

Diff for: tests/unittest.py

+5-16
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import gc
1717
import hashlib
1818
import hmac
19-
import inspect
2019
import json
2120
import logging
2221
import secrets
@@ -519,33 +518,23 @@ def pump(self, by=0.0):
519518
self.reactor.pump([by] * 100)
520519

521520
def get_success(self, d, by=0.0):
522-
if inspect.isawaitable(d):
523-
d = ensureDeferred(d)
524-
if not isinstance(d, Deferred):
525-
return d
521+
deferred: Deferred[TV] = ensureDeferred(d)
526522
self.pump(by=by)
527-
return self.successResultOf(d)
523+
return self.successResultOf(deferred)
528524

529525
def get_failure(self, d, exc):
530526
"""
531527
Run a Deferred and get a Failure from it. The failure must be of the type `exc`.
532528
"""
533-
if inspect.isawaitable(d):
534-
d = ensureDeferred(d)
535-
if not isinstance(d, Deferred):
536-
return d
529+
deferred: Deferred[Any] = ensureDeferred(d)
537530
self.pump()
538-
return self.failureResultOf(d, exc)
531+
return self.failureResultOf(deferred, exc)
539532

540533
def get_success_or_raise(self, d, by=0.0):
541534
"""Drive deferred to completion and return result or raise exception
542535
on failure.
543536
"""
544-
545-
if inspect.isawaitable(d):
546-
deferred = ensureDeferred(d)
547-
if not isinstance(deferred, Deferred):
548-
return d
537+
deferred: Deferred[TV] = ensureDeferred(d)
549538

550539
results: list = []
551540
deferred.addBoth(results.append)

0 commit comments

Comments
 (0)