Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 8bfb649

Browse files
committed
Merge tag 'v1.37.0rc1' into hs/hacked-together-event-cache
Synapse 1.37.0rc1 (2021-06-24) ============================== This release deprecates the current spam checker interface. See the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#deprecation-of-the-current-spam-checker-interface) for more information on how to update to the new generic module interface. This release also removes support for fetching and renewing TLS certificates using the ACME v1 protocol, which has been fully decommissioned by Let's Encrypt on June 1st 2021. Admins previously using this feature should use a [reverse proxy](https://matrix-org.github.io/synapse/develop/reverse_proxy.html) to handle TLS termination, or use an external ACME client (such as [certbot](https://certbot.eff.org/)) to retrieve a certificate and key and provide them to Synapse using the `tls_certificate_path` and `tls_private_key_path` configuration settings. Features -------- - Implement "room knocking" as per [MSC2403](matrix-org/matrix-spec-proposals#2403). Contributed by @Sorunome and anoa. ([\#6739](#6739), [\#9359](#9359), [\#10167](#10167), [\#10212](#10212), [\#10227](#10227)) - Add experimental support for backfilling history into rooms ([MSC2716](matrix-org/matrix-spec-proposals#2716)). ([\#9247](#9247)) - Implement a generic interface for third-party plugin modules. ([\#10062](#10062), [\#10206](#10206)) - Implement config option `sso.update_profile_information` to sync SSO users' profile information with the identity provider each time they login. Currently only displayname is supported. ([\#10108](#10108)) - Ensure that errors during startup are written to the logs and the console. ([\#10191](#10191)) Bugfixes -------- - Fix a bug introduced in Synapse v1.25.0 that prevented the `ip_range_whitelist` configuration option from working for federation and identity servers. Contributed by @mikure. ([\#10115](#10115)) - Remove a broken import line in Synapse's `admin_cmd` worker. Broke in Synapse v1.33.0. ([\#10154](#10154)) - Fix a bug introduced in Synapse v1.21.0 which could cause `/sync` to return immediately with an empty response. ([\#10157](#10157), [\#10158](#10158)) - Fix a minor bug in the response to `/_matrix/client/r0/user/{user}/openid/request_token` causing `expires_in` to be a float instead of an integer. Contributed by @lukaslihotzki. ([\#10175](#10175)) - Always require users to re-authenticate for dangerous operations: deactivating an account, modifying an account password, and adding 3PIDs. ([\#10184](#10184)) - Fix a bug introduced in Synpase v1.7.2 where remote server count metrics collection would be incorrectly delayed on startup. Found by @heftig. ([\#10195](#10195)) - Fix a bug introduced in Synapse v1.35.1 where an `allow` key of a `m.room.join_rules` event could be applied for incorrect room versions and configurations. ([\#10208](#10208)) - Fix performance regression in responding to user key requests over federation. Introduced in Synapse v1.34.0rc1. ([\#10221](#10221)) Improved Documentation ---------------------- - Add a new guide to decoding request logs. ([\#8436](#8436)) - Mention in the sample homeserver config that you may need to configure max upload size in your reverse proxy. Contributed by @aaronraimist. ([\#10122](#10122)) - Fix broken links in documentation. ([\#10180](#10180)) - Deploy a snapshot of the documentation website upon each new Synapse release. ([\#10198](#10198)) Deprecations and Removals ------------------------- - The current spam checker interface is deprecated in favour of a new generic modules system. See the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#deprecation-of-the-current-spam-checker-interface) for more information on how to update to the new system. ([\#10062](#10062), [\#10210](#10210), [\#10238](#10238)) - Stop supporting the unstable spaces prefixes from MSC1772. ([\#10161](#10161)) - Remove Synapse's support for automatically fetching and renewing certificates using the ACME v1 protocol. This protocol has been fully turned off by Let's Encrypt for existing installations on June 1st 2021. Admins previously using this feature should use a [reverse proxy](https://matrix-org.github.io/synapse/develop/reverse_proxy.html) to handle TLS termination, or use an external ACME client (such as [certbot](https://certbot.eff.org/)) to retrieve a certificate and key and provide them to Synapse using the `tls_certificate_path` and `tls_private_key_path` configuration settings. ([\#10194](#10194)) Internal Changes ---------------- - Update the database schema versioning to support gradual migration away from legacy tables. ([\#9933](#9933)) - Add type hints to the federation servlets. ([\#10080](#10080)) - Improve OpenTracing for event persistence. ([\#10134](#10134), [\#10193](#10193)) - Clean up the interface for injecting OpenTracing over HTTP. ([\#10143](#10143)) - Limit the number of in-flight `/keys/query` requests from a single device. ([\#10144](#10144)) - Refactor EventPersistenceQueue. ([\#10145](#10145)) - Document `SYNAPSE_TEST_LOG_LEVEL` to see the logger output when running tests. ([\#10148](#10148)) - Update the Complement build tags in GitHub Actions to test currently experimental features. ([\#10155](#10155)) - Add a `synapse_federation_soft_failed_events_total` metric to track how often events are soft failed. ([\#10156](#10156)) - Fetch the corresponding complement branch when performing CI. ([\#10160](#10160)) - Add some developer documentation about boolean columns in database schemas. ([\#10164](#10164)) - Add extra logging fields to better debug where events are being soft failed. ([\#10168](#10168)) - Add debug logging for when we enter and exit `Measure` blocks. ([\#10183](#10183)) - Improve comments in structured logging code. ([\#10188](#10188)) - Update [MSC3083](matrix-org/matrix-spec-proposals#3083) support with modifications from the MSC. ([\#10189](#10189)) - Remove redundant DNS lookup limiter. ([\#10190](#10190)) - Upgrade `black` linting tool to 21.6b0. ([\#10197](#10197)) - Expose OpenTracing trace id in response headers. ([\#10199](#10199))
2 parents 7d33ba7 + bb472f3 commit 8bfb649

File tree

140 files changed

+4722
-2004
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

140 files changed

+4722
-2004
lines changed

.github/workflows/docs.yaml

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ name: Deploy the documentation
33
on:
44
push:
55
branches:
6+
# For bleeding-edge documentation
67
- develop
8+
# For documentation specific to a release
9+
- 'release-v*'
710

811
workflow_dispatch:
912

@@ -22,10 +25,40 @@ jobs:
2225
- name: Build the documentation
2326
run: mdbook build
2427

28+
# Deploy to the latest documentation directories
2529
- name: Deploy latest documentation
2630
uses: peaceiris/actions-gh-pages@068dc23d9710f1ba62e86896f84735d869951305 # v3.8.0
2731
with:
2832
github_token: ${{ secrets.GITHUB_TOKEN }}
2933
keep_files: true
3034
publish_dir: ./book
3135
destination_dir: ./develop
36+
37+
- name: Get the current Synapse version
38+
id: vars
39+
# The $GITHUB_REF value for a branch looks like `refs/heads/release-v1.2`. We do some
40+
# shell magic to remove the "refs/heads/release-v" bit from this, to end up with "1.2",
41+
# our major/minor version number, and set this to a var called `branch-version`.
42+
#
43+
# We then use some python to get Synapse's full version string, which may look
44+
# like "1.2.3rc4". We set this to a var called `synapse-version`. We use this
45+
# to determine if this release is still an RC, and if so block deployment.
46+
run: |
47+
echo ::set-output name=branch-version::${GITHUB_REF#refs/heads/release-v}
48+
echo ::set-output name=synapse-version::`python3 -c 'import synapse; print(synapse.__version__)'`
49+
50+
# Deploy to the version-specific directory
51+
- name: Deploy release-specific documentation
52+
# We only carry out this step if we're running on a release branch,
53+
# and the current Synapse version does not have "rc" in the name.
54+
#
55+
# The result is that only full releases are deployed, but can be
56+
# updated if the release branch gets retroactive fixes.
57+
if: ${{ startsWith( github.ref, 'refs/heads/release-v' ) && !contains( steps.vars.outputs.synapse-version, 'rc') }}
58+
uses: peaceiris/actions-gh-pages@v3
59+
with:
60+
github_token: ${{ secrets.GITHUB_TOKEN }}
61+
keep_files: true
62+
publish_dir: ./book
63+
# The resulting documentation will end up in a directory named `vX.Y`.
64+
destination_dir: ./v${{ steps.vars.outputs.branch-version }}

.github/workflows/tests.yml

Lines changed: 24 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -305,11 +305,29 @@ jobs:
305305
with:
306306
path: synapse
307307

308-
- name: Run actions/checkout@v2 for complement
309-
uses: actions/checkout@v2
310-
with:
311-
repository: "matrix-org/complement"
312-
path: complement
308+
# Attempt to check out the same branch of Complement as the PR. If it
309+
# doesn't exist, fallback to master.
310+
- name: Checkout complement
311+
shell: bash
312+
run: |
313+
mkdir -p complement
314+
# Attempt to use the version of complement which best matches the current
315+
# build. Depending on whether this is a PR or release, etc. we need to
316+
# use different fallbacks.
317+
#
318+
# 1. First check if there's a similarly named branch (GITHUB_HEAD_REF
319+
# for pull requests, otherwise GITHUB_REF).
320+
# 2. Attempt to use the base branch, e.g. when merging into release-vX.Y
321+
# (GITHUB_BASE_REF for pull requests).
322+
# 3. Use the default complement branch ("master").
323+
for BRANCH_NAME in "$GITHUB_HEAD_REF" "$GITHUB_BASE_REF" "${GITHUB_REF#refs/heads/}" "master"; do
324+
# Skip empty branch names and merge commits.
325+
if [[ -z "$BRANCH_NAME" || $BRANCH_NAME =~ ^refs/pull/.* ]]; then
326+
continue
327+
fi
328+
329+
(wget -O - "https://github.com/matrix-org/complement/archive/$BRANCH_NAME.tar.gz" | tar -xz --strip-components=1 -C complement) && break
330+
done
313331
314332
# Build initial Synapse image
315333
- run: docker build -t matrixdotorg/synapse:latest -f docker/Dockerfile .
@@ -322,7 +340,7 @@ jobs:
322340
working-directory: complement/dockerfiles
323341

324342
# Run Complement
325-
- run: go test -v -tags synapse_blacklist ./tests
343+
- run: go test -v -tags synapse_blacklist,msc2403,msc2946,msc3083 ./tests
326344
env:
327345
COMPLEMENT_BASE_IMAGE: complement-synapse:latest
328346
working-directory: complement

CHANGES.md

Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,74 @@
1+
Synapse 1.37.0rc1 (2021-06-24)
2+
==============================
3+
4+
This release deprecates the current spam checker interface. See the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#deprecation-of-the-current-spam-checker-interface) for more information on how to update to the new generic module interface.
5+
6+
This release also removes support for fetching and renewing TLS certificates using the ACME v1 protocol, which has been fully decommissioned by Let's Encrypt on June 1st 2021. Admins previously using this feature should use a [reverse proxy](https://matrix-org.github.io/synapse/develop/reverse_proxy.html) to handle TLS termination, or use an external ACME client (such as [certbot](https://certbot.eff.org/)) to retrieve a certificate and key and provide them to Synapse using the `tls_certificate_path` and `tls_private_key_path` configuration settings.
7+
8+
9+
Features
10+
--------
11+
12+
- Implement "room knocking" as per [MSC2403](https://github.com/matrix-org/matrix-doc/pull/2403). Contributed by @Sorunome and anoa. ([\#6739](https://github.com/matrix-org/synapse/issues/6739), [\#9359](https://github.com/matrix-org/synapse/issues/9359), [\#10167](https://github.com/matrix-org/synapse/issues/10167), [\#10212](https://github.com/matrix-org/synapse/issues/10212), [\#10227](https://github.com/matrix-org/synapse/issues/10227))
13+
- Add experimental support for backfilling history into rooms ([MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716)). ([\#9247](https://github.com/matrix-org/synapse/issues/9247))
14+
- Implement a generic interface for third-party plugin modules. ([\#10062](https://github.com/matrix-org/synapse/issues/10062), [\#10206](https://github.com/matrix-org/synapse/issues/10206))
15+
- Implement config option `sso.update_profile_information` to sync SSO users' profile information with the identity provider each time they login. Currently only displayname is supported. ([\#10108](https://github.com/matrix-org/synapse/issues/10108))
16+
- Ensure that errors during startup are written to the logs and the console. ([\#10191](https://github.com/matrix-org/synapse/issues/10191))
17+
18+
19+
Bugfixes
20+
--------
21+
22+
- Fix a bug introduced in Synapse v1.25.0 that prevented the `ip_range_whitelist` configuration option from working for federation and identity servers. Contributed by @mikure. ([\#10115](https://github.com/matrix-org/synapse/issues/10115))
23+
- Remove a broken import line in Synapse's `admin_cmd` worker. Broke in Synapse v1.33.0. ([\#10154](https://github.com/matrix-org/synapse/issues/10154))
24+
- Fix a bug introduced in Synapse v1.21.0 which could cause `/sync` to return immediately with an empty response. ([\#10157](https://github.com/matrix-org/synapse/issues/10157), [\#10158](https://github.com/matrix-org/synapse/issues/10158))
25+
- Fix a minor bug in the response to `/_matrix/client/r0/user/{user}/openid/request_token` causing `expires_in` to be a float instead of an integer. Contributed by @lukaslihotzki. ([\#10175](https://github.com/matrix-org/synapse/issues/10175))
26+
- Always require users to re-authenticate for dangerous operations: deactivating an account, modifying an account password, and adding 3PIDs. ([\#10184](https://github.com/matrix-org/synapse/issues/10184))
27+
- Fix a bug introduced in Synpase v1.7.2 where remote server count metrics collection would be incorrectly delayed on startup. Found by @heftig. ([\#10195](https://github.com/matrix-org/synapse/issues/10195))
28+
- Fix a bug introduced in Synapse v1.35.1 where an `allow` key of a `m.room.join_rules` event could be applied for incorrect room versions and configurations. ([\#10208](https://github.com/matrix-org/synapse/issues/10208))
29+
- Fix performance regression in responding to user key requests over federation. Introduced in Synapse v1.34.0rc1. ([\#10221](https://github.com/matrix-org/synapse/issues/10221))
30+
31+
32+
Improved Documentation
33+
----------------------
34+
35+
- Add a new guide to decoding request logs. ([\#8436](https://github.com/matrix-org/synapse/issues/8436))
36+
- Mention in the sample homeserver config that you may need to configure max upload size in your reverse proxy. Contributed by @aaronraimist. ([\#10122](https://github.com/matrix-org/synapse/issues/10122))
37+
- Fix broken links in documentation. ([\#10180](https://github.com/matrix-org/synapse/issues/10180))
38+
- Deploy a snapshot of the documentation website upon each new Synapse release. ([\#10198](https://github.com/matrix-org/synapse/issues/10198))
39+
40+
41+
Deprecations and Removals
42+
-------------------------
43+
44+
- The current spam checker interface is deprecated in favour of a new generic modules system. See the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#deprecation-of-the-current-spam-checker-interface) for more information on how to update to the new system. ([\#10062](https://github.com/matrix-org/synapse/issues/10062), [\#10210](https://github.com/matrix-org/synapse/issues/10210), [\#10238](https://github.com/matrix-org/synapse/issues/10238))
45+
- Stop supporting the unstable spaces prefixes from MSC1772. ([\#10161](https://github.com/matrix-org/synapse/issues/10161))
46+
- Remove Synapse's support for automatically fetching and renewing certificates using the ACME v1 protocol. This protocol has been fully turned off by Let's Encrypt for existing installations on June 1st 2021. Admins previously using this feature should use a [reverse proxy](https://matrix-org.github.io/synapse/develop/reverse_proxy.html) to handle TLS termination, or use an external ACME client (such as [certbot](https://certbot.eff.org/)) to retrieve a certificate and key and provide them to Synapse using the `tls_certificate_path` and `tls_private_key_path` configuration settings. ([\#10194](https://github.com/matrix-org/synapse/issues/10194))
47+
48+
49+
Internal Changes
50+
----------------
51+
52+
- Update the database schema versioning to support gradual migration away from legacy tables. ([\#9933](https://github.com/matrix-org/synapse/issues/9933))
53+
- Add type hints to the federation servlets. ([\#10080](https://github.com/matrix-org/synapse/issues/10080))
54+
- Improve OpenTracing for event persistence. ([\#10134](https://github.com/matrix-org/synapse/issues/10134), [\#10193](https://github.com/matrix-org/synapse/issues/10193))
55+
- Clean up the interface for injecting OpenTracing over HTTP. ([\#10143](https://github.com/matrix-org/synapse/issues/10143))
56+
- Limit the number of in-flight `/keys/query` requests from a single device. ([\#10144](https://github.com/matrix-org/synapse/issues/10144))
57+
- Refactor EventPersistenceQueue. ([\#10145](https://github.com/matrix-org/synapse/issues/10145))
58+
- Document `SYNAPSE_TEST_LOG_LEVEL` to see the logger output when running tests. ([\#10148](https://github.com/matrix-org/synapse/issues/10148))
59+
- Update the Complement build tags in GitHub Actions to test currently experimental features. ([\#10155](https://github.com/matrix-org/synapse/issues/10155))
60+
- Add a `synapse_federation_soft_failed_events_total` metric to track how often events are soft failed. ([\#10156](https://github.com/matrix-org/synapse/issues/10156))
61+
- Fetch the corresponding complement branch when performing CI. ([\#10160](https://github.com/matrix-org/synapse/issues/10160))
62+
- Add some developer documentation about boolean columns in database schemas. ([\#10164](https://github.com/matrix-org/synapse/issues/10164))
63+
- Add extra logging fields to better debug where events are being soft failed. ([\#10168](https://github.com/matrix-org/synapse/issues/10168))
64+
- Add debug logging for when we enter and exit `Measure` blocks. ([\#10183](https://github.com/matrix-org/synapse/issues/10183))
65+
- Improve comments in structured logging code. ([\#10188](https://github.com/matrix-org/synapse/issues/10188))
66+
- Update [MSC3083](https://github.com/matrix-org/matrix-doc/pull/3083) support with modifications from the MSC. ([\#10189](https://github.com/matrix-org/synapse/issues/10189))
67+
- Remove redundant DNS lookup limiter. ([\#10190](https://github.com/matrix-org/synapse/issues/10190))
68+
- Upgrade `black` linting tool to 21.6b0. ([\#10197](https://github.com/matrix-org/synapse/issues/10197))
69+
- Expose OpenTracing trace id in response headers. ([\#10199](https://github.com/matrix-org/synapse/issues/10199))
70+
71+
172
Synapse 1.36.0 (2021-06-15)
273
===========================
374

CONTRIBUTING.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,12 +173,19 @@ source ./env/bin/activate
173173
trial tests.rest.admin.test_room tests.handlers.test_admin.ExfiltrateData.test_invite
174174
```
175175

176-
If your tests fail, you may wish to look at the logs:
176+
If your tests fail, you may wish to look at the logs (the default log level is `ERROR`):
177177

178178
```sh
179179
less _trial_temp/test.log
180180
```
181181

182+
To increase the log level for the tests, set `SYNAPSE_TEST_LOG_LEVEL`:
183+
184+
```sh
185+
SYNAPSE_TEST_LOG_LEVEL=DEBUG trial tests
186+
```
187+
188+
182189
## Run the integration tests.
183190

184191
The integration tests are a more comprehensive suite of tests. They

INSTALL.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -442,10 +442,7 @@ so, you will need to edit `homeserver.yaml`, as follows:
442442
443443
- You will also need to uncomment the `tls_certificate_path` and
444444
`tls_private_key_path` lines under the `TLS` section. You will need to manage
445-
provisioning of these certificates yourself — Synapse had built-in ACME
446-
support, but the ACMEv1 protocol Synapse implements is deprecated, not
447-
allowed by LetsEncrypt for new sites, and will break for existing sites in
448-
late 2020. See [ACME.md](docs/ACME.md).
445+
provisioning of these certificates yourself.
449446

450447
If you are using your own certificate, be sure to use a `.pem` file that
451448
includes the full certificate chain including any intermediate certificates

README.rst

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -142,13 +142,6 @@ the form of::
142142
As when logging in, you will need to specify a "Custom server". Specify your
143143
desired ``localpart`` in the 'User name' box.
144144

145-
ACME setup
146-
==========
147-
148-
For details on having Synapse manage your federation TLS certificates
149-
automatically, please see `<docs/ACME.md>`_.
150-
151-
152145
Security note
153146
=============
154147

@@ -293,18 +286,6 @@ try installing the failing modules individually::
293286

294287
pip install -e "module-name"
295288

296-
Once this is done, you may wish to run Synapse's unit tests to
297-
check that everything is installed correctly::
298-
299-
python -m twisted.trial tests
300-
301-
This should end with a 'PASSED' result (note that exact numbers will
302-
differ)::
303-
304-
Ran 1337 tests in 716.064s
305-
306-
PASSED (skips=15, successes=1322)
307-
308289
We recommend using the demo which starts 3 federated instances running on ports `8080` - `8082`
309290

310291
./demo/start.sh
@@ -324,6 +305,23 @@ If you just want to start a single instance of the app and run it directly::
324305
python -m synapse.app.homeserver --config-path homeserver.yaml
325306

326307

308+
Running the unit tests
309+
======================
310+
311+
After getting up and running, you may wish to run Synapse's unit tests to
312+
check that everything is installed correctly::
313+
314+
trial tests
315+
316+
This should end with a 'PASSED' result (note that exact numbers will
317+
differ)::
318+
319+
Ran 1337 tests in 716.064s
320+
321+
PASSED (skips=15, successes=1322)
322+
323+
For more tips on running the unit tests, like running a specific test or
324+
to see the logging output, see the `CONTRIBUTING doc <CONTRIBUTING.md#run-the-unit-tests>`_.
327325

328326

329327
Running the Integration Tests

UPGRADE.rst

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,23 @@ for example:
8585
wget https://packages.matrix.org/debian/pool/main/m/matrix-synapse-py3/matrix-synapse-py3_1.3.0+stretch1_amd64.deb
8686
dpkg -i matrix-synapse-py3_1.3.0+stretch1_amd64.deb
8787
88+
Upgrading to v1.37.0
89+
====================
90+
91+
Deprecation of the current spam checker interface
92+
-------------------------------------------------
93+
94+
The current spam checker interface is deprecated in favour of a new generic modules system.
95+
Authors of spam checker modules can refer to `this documentation <https://matrix-org.github.io/synapse/develop/modules.html#porting-an-existing-module-that-uses-the-old-interface>`_
96+
to update their modules. Synapse administrators can refer to `this documentation <https://matrix-org.github.io/synapse/develop/modules.html#using-modules>`_
97+
to update their configuration once the modules they are using have been updated.
98+
99+
We plan to remove support for the current spam checker interface in August 2021.
100+
101+
More module interfaces will be ported over to this new generic system in future versions
102+
of Synapse.
103+
104+
88105
Upgrading to v1.34.0
89106
====================
90107

contrib/experiments/cursesio.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,14 @@ def set_callback(self, callback):
4646
self.callback = callback
4747

4848
def fileno(self):
49-
""" We want to select on FD 0 """
49+
"""We want to select on FD 0"""
5050
return 0
5151

5252
def connectionLost(self, reason):
5353
self.close()
5454

5555
def print_line(self, text):
56-
""" add a line to the internal list of lines"""
56+
"""add a line to the internal list of lines"""
5757

5858
self.lines.append(text)
5959
self.redraw()
@@ -92,7 +92,7 @@ def printLogLine(self, text):
9292
)
9393

9494
def doRead(self):
95-
""" Input is ready! """
95+
"""Input is ready!"""
9696
curses.noecho()
9797
c = self.stdscr.getch() # read a character
9898

@@ -132,7 +132,7 @@ def logPrefix(self):
132132
return "CursesStdIO"
133133

134134
def close(self):
135-
""" clean up """
135+
"""clean up"""
136136

137137
curses.nocbreak()
138138
self.stdscr.keypad(0)

docker/conf/homeserver.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,6 @@
77
tls_certificate_path: "/data/{{ SYNAPSE_SERVER_NAME }}.tls.crt"
88
tls_private_key_path: "/data/{{ SYNAPSE_SERVER_NAME }}.tls.key"
99

10-
{% if SYNAPSE_ACME %}
11-
acme:
12-
enabled: true
13-
port: 8009
14-
{% endif %}
15-
1610
{% endif %}
1711

1812
## Server ##

0 commit comments

Comments
 (0)