Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 904bb04

Browse files
authored
Fix sample_config.yaml in regards track_puppeted_user_ips (#11749)
* Fix sample_config.yaml in regards track_puppeted_user_ips Closes #11741 Signed-off-by: Jason Robinson <[email protected]>
1 parent 3e0536c commit 904bb04

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

changelog.d/11749.feature

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Add `track_puppeted_user_ips` config flag to track puppeted user IP addresses. This also includes them in monthly active user counts.

docs/sample_config.yaml

+6-5
Original file line numberDiff line numberDiff line change
@@ -1503,11 +1503,12 @@ room_prejoin_state:
15031503
#additional_event_types:
15041504
# - org.example.custom.event.type
15051505

1506-
# If enabled, puppeted user IP's can also be tracked. By default when
1507-
# puppeting another user, the user who has created the access token
1508-
# for puppeting is tracked. If this is enabled, both requests are tracked.
1509-
# Implicitly enables MAU tracking for puppeted users.
1510-
#track_puppeted_user_ips: false
1506+
# By default when puppeting another user, the user who has created the
1507+
# access token for puppeting is tracked. If this is enabled, both
1508+
# requests are tracked. Implicitly enables MAU tracking for puppeted users.
1509+
# Uncomment to also track puppeted user IP's.
1510+
#
1511+
#track_puppeted_user_ips: true
15111512

15121513

15131514
# A list of application service config files to use

synapse/config/api.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,12 @@ def generate_config_section(cls, **kwargs) -> str:
6161
#additional_event_types:
6262
# - org.example.custom.event.type
6363
64-
# If enabled, puppeted user IP's can also be tracked. By default when
65-
# puppeting another user, the user who has created the access token
66-
# for puppeting is tracked. If this is enabled, both requests are tracked.
67-
# Implicitly enables MAU tracking for puppeted users.
68-
#track_puppeted_user_ips: false
64+
# By default when puppeting another user, the user who has created the
65+
# access token for puppeting is tracked. If this is enabled, both
66+
# requests are tracked. Implicitly enables MAU tracking for puppeted users.
67+
# Uncomment to also track puppeted user IP's.
68+
#
69+
#track_puppeted_user_ips: true
6970
""" % {
7071
"formatted_default_state_types": formatted_default_state_types
7172
}

0 commit comments

Comments
 (0)