Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 9473ebb

Browse files
author
David Robertson
committed
Revert "Fix event size checks (#13710)"
This reverts commit fab495a. As noted in #13710 (comment): > We want to see this change land for the protocol's sake (and plan to un-revert it) but want to give this a little more time before releasing this.
1 parent b922b54 commit 9473ebb

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

changelog.d/13710.bugfix

-1
This file was deleted.

synapse/event_auth.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -342,15 +342,15 @@ def check_state_dependent_auth_rules(
342342

343343

344344
def _check_size_limits(event: "EventBase") -> None:
345-
if len(event.user_id.encode("utf-8")) > 255:
345+
if len(event.user_id) > 255:
346346
raise EventSizeError("'user_id' too large")
347-
if len(event.room_id.encode("utf-8")) > 255:
347+
if len(event.room_id) > 255:
348348
raise EventSizeError("'room_id' too large")
349-
if event.is_state() and len(event.state_key.encode("utf-8")) > 255:
349+
if event.is_state() and len(event.state_key) > 255:
350350
raise EventSizeError("'state_key' too large")
351-
if len(event.type.encode("utf-8")) > 255:
351+
if len(event.type) > 255:
352352
raise EventSizeError("'type' too large")
353-
if len(event.event_id.encode("utf-8")) > 255:
353+
if len(event.event_id) > 255:
354354
raise EventSizeError("'event_id' too large")
355355
if len(encode_canonical_json(event.get_pdu_json())) > MAX_PDU_SIZE:
356356
raise EventSizeError("event too large")

0 commit comments

Comments
 (0)