Increase default max_upload_size from 10M to 50M (#8502)

Akkowicz · web-flow · commit ca2db5dd0c9f · 2020-10-09T16:58:23.000+01:00
Signed-off-by: Mateusz Przybyłowicz &lt;uamfhq@gmail.com&gt;
diff --git a/changelog.d/8502.feature b/changelog.d/8502.feature
@@ -0,0 +1 @@
+Increase default upload size limit from 10M to 50M. Contributed by @Akkowicz.
diff --git a/docker/conf/homeserver.yaml b/docker/conf/homeserver.yaml
@@ -90,7 +90,7 @@ federation_rc_concurrent: 3
 
 media_store_path: "/data/media"
 uploads_path: "/data/uploads"
-max_upload_size: "{{ SYNAPSE_MAX_UPLOAD_SIZE or "10M" }}"
+max_upload_size: "{{ SYNAPSE_MAX_UPLOAD_SIZE or "50M" }}"
 max_image_pixels: "32M"
 dynamic_thumbnails: false
 
diff --git a/docs/reverse_proxy.md b/docs/reverse_proxy.md
@@ -54,7 +54,7 @@ server {
         proxy_set_header X-Forwarded-For $remote_addr;
         # Nginx by default only allows file uploads up to 1M in size
         # Increase client_max_body_size to match max_upload_size defined in homeserver.yaml
-        client_max_body_size 10M;
+        client_max_body_size 50M;
     }
 }
 ```
diff --git a/docs/sample_config.yaml b/docs/sample_config.yaml
@@ -893,7 +893,7 @@ media_store_path: "DATADIR/media_store"
 
 # The largest allowed upload size in bytes
 #
-#max_upload_size: 10M
+#max_upload_size: 50M
 
 # Maximum number of pixels that will be thumbnailed
 #
diff --git a/synapse/config/repository.py b/synapse/config/repository.py
@@ -100,7 +100,7 @@ def read_config(self, config, **kwargs):
             "media_instance_running_background_jobs",
         )
 
-        self.max_upload_size = self.parse_size(config.get("max_upload_size", "10M"))
+        self.max_upload_size = self.parse_size(config.get("max_upload_size", "50M"))
         self.max_image_pixels = self.parse_size(config.get("max_image_pixels", "32M"))
         self.max_spider_size = self.parse_size(config.get("max_spider_size", "10M"))
 
@@ -242,7 +242,7 @@ def generate_config_section(self, data_dir_path, **kwargs):
 
         # The largest allowed upload size in bytes
         #
-        #max_upload_size: 10M
+        #max_upload_size: 50M
 
         # Maximum number of pixels that will be thumbnailed
         #

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Increase default upload size limit from 10M to 50M. Contributed by @Akkowicz.`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ server {`
`54`	`54`	`proxy_set_header X-Forwarded-For $remote_addr;`
`55`	`55`	`# Nginx by default only allows file uploads up to 1M in size`
`56`	`56`	`# Increase client_max_body_size to match max_upload_size defined in homeserver.yaml`
`57`		`- client_max_body_size 10M;`
	`57`	`+ client_max_body_size 50M;`
`58`	`58`	`}`
`59`	`59`	`}`
`60`	`60`	```
Original file line number	Diff line number	Diff line change
`@@ -893,7 +893,7 @@ media_store_path: "DATADIR/media_store"`
`893`	`893`
`894`	`894`	`# The largest allowed upload size in bytes`
`895`	`895`	`#`
`896`		`-#max_upload_size: 10M`
	`896`	`+#max_upload_size: 50M`
`897`	`897`
`898`	`898`	`# Maximum number of pixels that will be thumbnailed`
`899`	`899`	`#`
Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ def read_config(self, config, **kwargs):`
`100`	`100`	`"media_instance_running_background_jobs",`
`101`	`101`	`)`
`102`	`102`
`103`		`- self.max_upload_size = self.parse_size(config.get("max_upload_size", "10M"))`
	`103`	`+ self.max_upload_size = self.parse_size(config.get("max_upload_size", "50M"))`
`104`	`104`	`self.max_image_pixels = self.parse_size(config.get("max_image_pixels", "32M"))`
`105`	`105`	`self.max_spider_size = self.parse_size(config.get("max_spider_size", "10M"))`
`106`	`106`
`@@ -242,7 +242,7 @@ def generate_config_section(self, data_dir_path, **kwargs):`
`242`	`242`
`243`	`243`	`# The largest allowed upload size in bytes`
`244`	`244`	`#`
`245`		`- #max_upload_size: 10M`
	`245`	`+ #max_upload_size: 50M`
`246`	`246`
`247`	`247`	`# Maximum number of pixels that will be thumbnailed`
`248`	`248`	`#`