Actually fix bad logging rejecting incoming transactions

David Robertson · David Robertson · commit e21a6d2103f1 · 2022-02-28T12:10:32.000Z
diff --git a/synapse/federation/transport/server/federation.py b/synapse/federation/transport/server/federation.py
@@ -110,7 +110,7 @@ async def on_PUT(
             if issue_8631_logger.isEnabledFor(logging.DEBUG):
                 DEVICE_UPDATE_EDUS = ["m.device_list_update", "m.signing_key_update"]
                 device_list_updates = [
-                    edu.content
+                    edu.get("content", {})
                     for edu in transaction_data.get("edus", [])
                     if edu.get("edu_type") in DEVICE_UPDATE_EDUS
                 ]

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ async def on_PUT(`
`110`	`110`	`if issue_8631_logger.isEnabledFor(logging.DEBUG):`
`111`	`111`	`DEVICE_UPDATE_EDUS = ["m.device_list_update", "m.signing_key_update"]`
`112`	`112`	`device_list_updates = [`
`113`		`- edu.content`
	`113`	`+ edu.get("content", {})`
`114`	`114`	`for edu in transaction_data.get("edus", [])`
`115`	`115`	`if edu.get("edu_type") in DEVICE_UPDATE_EDUS`
`116`	`116`	`]`