Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit f58b300

Browse files
authored
Do not attempt to bundled aggregations for /members and /state. (#11623)
Both of those APIs return state events, which will not have bundled aggregations added anyway.
1 parent 15bb1c8 commit f58b300

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

changelog.d/11623.bugfix

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix a long-standing bug where responses included bundled aggregations when they should not, per [MSC2675](https://github.com/matrix-org/matrix-doc/pull/2675).

synapse/handlers/message.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,7 @@ async def get_state_events(
246246
room_state = room_state_events[membership_event_id]
247247

248248
now = self.clock.time_msec()
249-
events = await self._event_serializer.serialize_events(
250-
room_state.values(), now, bundle_aggregations=True
251-
)
249+
events = await self._event_serializer.serialize_events(room_state.values(), now)
252250
return events
253251

254252
async def get_joined_members(self, requester: Requester, room_id: str) -> dict:

0 commit comments

Comments
 (0)