Merge pull request #43 from borigas/FinalizerDeadlock

Finalizer deadlock

Author: Matteo Bortolazzo

src/CouchDB.Driver/CouchClient.cs

@@ -303,7 +303,10 @@ public void Dispose()
 
         protected virtual void Dispose(bool disposing)
         {
-            AsyncContext.Run(() => LogoutAsync());
+            if (_settings.AuthenticationType == AuthenticationType.Cookie && _settings.LogOutOnDispose)
+            {
+                AsyncContext.Run(() => LogoutAsync().ConfigureAwait(false));
+            }
             _flurlClient.Dispose();
         }
 

src/CouchDB.Driver/Settings/CouchSettings.cs

@@ -23,6 +23,7 @@ public class CouchSettings
         internal DocumentCaseType DocumentsCaseType { get; private set; }
         internal PropertyCaseType PropertiesCase { get; private set; }
         internal bool CheckDatabaseExists { get; private set; }
+        internal bool LogOutOnDispose { get; private set; }
         internal Func<HttpRequestMessage, X509Certificate2, X509Chain, SslPolicyErrors, bool> ServerCertificateCustomValidationCallback { get; private set; }
 
         internal CouchSettings()
@@ -31,6 +32,7 @@ internal CouchSettings()
             PluralizeEntitis = true;
             DocumentsCaseType = DocumentCaseType.UnderscoreCase;
             PropertiesCase = PropertyCaseType.CamelCase;
+            LogOutOnDispose = true;
         }
 
         /// <summary>
@@ -144,5 +146,11 @@ public CouchSettings EnsureDatabaseExists()
             CheckDatabaseExists = true;
             return this;
         }
+
+        public CouchSettings DisableLogOutOnDispose()
+        {
+            LogOutOnDispose = false;
+            return this;
+        }
     }
 }