Skip to content

Commit e830c04

Browse files
committed
Fix TestQueryer test to use exec for multistatement insertion
1 parent fdbe1b0 commit e830c04

File tree

1 file changed

+18
-10
lines changed

1 file changed

+18
-10
lines changed

sqlite3_test.go

+18-10
Original file line numberDiff line numberDiff line change
@@ -1063,36 +1063,44 @@ func TestQueryer(t *testing.T) {
10631063
defer db.Close()
10641064

10651065
_, err = db.Exec(`
1066-
create table foo (id integer);
1066+
create table foo (id integer);
10671067
`)
10681068
if err != nil {
10691069
t.Error("Failed to call db.Query:", err)
10701070
}
10711071

1072-
rows, err := db.Query(`
1073-
insert into foo(id) values(?);
1074-
insert into foo(id) values(?);
1075-
insert into foo(id) values(?);
1076-
select id from foo order by id;
1072+
_, err = db.Exec(`
1073+
insert into foo(id) values(?);
1074+
insert into foo(id) values(?);
1075+
insert into foo(id) values(?);
10771076
`, 3, 2, 1)
1077+
if err != nil {
1078+
t.Error("Failed to call db.Exec:", err)
1079+
}
1080+
rows, err := db.Query(`
1081+
select id from foo order by id;
1082+
`)
10781083
if err != nil {
10791084
t.Error("Failed to call db.Query:", err)
10801085
}
10811086
defer rows.Close()
1082-
n := 1
1087+
n := 0
10831088
for rows.Next() {
10841089
var id int
10851090
err = rows.Scan(&id)
10861091
if err != nil {
10871092
t.Error("Failed to db.Query:", err)
10881093
}
1089-
if id != n {
1094+
if id != n + 1 {
10901095
t.Error("Failed to db.Query: not matched results")
10911096
}
10921097
n = n + 1
10931098
}
1094-
if n != 4 {
1095-
t.Errorf("Expected 3 rows but retrieved %v", n-1)
1099+
if err := rows.Err(); err != nil {
1100+
t.Errorf("Post-scan failed: %v\n", err)
1101+
}
1102+
if n != 3 {
1103+
t.Errorf("Expected 3 rows but retrieved %v", n)
10961104
}
10971105
}
10981106

0 commit comments

Comments
 (0)