Skip to content

Updating to Angular7 breaks when running ng:serve:web #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emcee22 opened this issue Oct 26, 2018 · 3 comments
Closed

Updating to Angular7 breaks when running ng:serve:web #267

emcee22 opened this issue Oct 26, 2018 · 3 comments

Comments

@emcee22
Copy link

emcee22 commented Oct 26, 2018

No description provided.

@AleksMeshkov
Copy link

AleksMeshkov commented Nov 2, 2018

As for me I've got it running with no problem.

image

I see only see some warnings in the console:

WARNING in ./node_modules/zone.js/dist/zone-mix.js
Module not found: Error: Can't resolve 'crypto' in '/Users/alekseymeshkov/Devel/angular-electron/node_modules/zone.js/dist'

WARNING in ./node_modules/zone.js/dist/zone-mix.js
Module not found: Error: Can't resolve 'fs' in '/Users/alekseymeshkov/Devel/angular-electron/node_modules/zone.js/dist'

WARNING in ./node_modules/zone.js/dist/zone-mix.js
Module not found: Error: Can't resolve 'timers' in '/Users/alekseymeshkov/Devel/angular-electron/node_modules/zone.js/dist'

I think I have this warnings because of using nodeJs 10

@DBnR1
Copy link

DBnR1 commented Nov 8, 2018

@AleksMeshkov I get the same Warnings as Errors and the build fails. Using Angular 6.1 and Node 8.11.

Clearing the code of all references to Electron and Node resolves this though. Just need better conditional importing I guess so that stuff isn't included if using ng:serve:web

@maximegris
Copy link
Owner

Replace content at the end of of polyfill.ts

[...] 
/***************************************************************************************************
 * Zone JS is required by default for Angular itself.
 */
import 'zone.js/dist/zone';  // Included with Angular CLI.


/***************************************************************************************************
 * APPLICATION IMPORTS
 */

It should remove errors.
I'm working on a new version of this project with Electron 3 + Angular 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants