Do not open indices with broken index settings

- remove the leniency on opening indices with unrecognized settings and
instead such an index will be closed
with the unrecognized settings archived
- do not open any index with archived settings
- users can remove archived settings via the wildcard archived
- return illegal_argument_exception  400 status code when trying
to open an index with broken/archived settings

Relates to elastic#26995

Closes elastic#26998

Author: mayya-sharipova

server/src/main/java/org/elasticsearch/ElasticsearchException.java

@@ -988,10 +988,7 @@ private enum ElasticsearchExceptionHandle {
                 org.elasticsearch.common.xcontent.NamedXContentRegistry.UnknownNamedObjectException::new, 148, Version.V_5_2_0),
         TOO_MANY_BUCKETS_EXCEPTION(MultiBucketConsumerService.TooManyBucketsException.class,
                                    MultiBucketConsumerService.TooManyBucketsException::new, 149,
-            Version.V_7_0_0_alpha1),
-        INDEX_OPEN_EXCEPTION(org.elasticsearch.indices.IndexOpenException.class,
-            org.elasticsearch.indices.IndexOpenException::new, 150, Version.V_6_3_0);
-
+            Version.V_7_0_0_alpha1);
 
         final Class<? extends ElasticsearchException> exceptionClass;
         final CheckedFunction<StreamInput, ? extends ElasticsearchException, IOException> constructor;

server/src/main/java/org/elasticsearch/cluster/metadata/MetaDataIndexStateService.java

@@ -39,7 +39,6 @@
 import org.elasticsearch.common.inject.Inject;
 import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.index.Index;
-import org.elasticsearch.indices.IndexOpenException;
 import org.elasticsearch.indices.IndicesService;
 import org.elasticsearch.rest.RestStatus;
 import org.elasticsearch.snapshots.RestoreService;
@@ -195,8 +194,7 @@ public ClusterState execute(ClusterState currentState) {
                     try {
                         indicesService.verifyIndexMetadata(indexMetaData, indexMetaData, false);
                     } catch (Exception e) {
-                        throw new IndexOpenException(indexMetaData.getIndex(),
-                            "Failed to open index! Failed to verify index " + indexMetaData.getIndex() + e.getMessage());
+                        throw new IllegalArgumentException("Failed to open index! Failed to verify index " + indexMetaData.getIndex(), e);
                     }
 
                     mdBuilder.put(indexMetaData, true);

server/src/main/java/org/elasticsearch/indices/IndexOpenException.java

@@ -815,7 +815,6 @@ public void testIds() {
         ids.put(147, org.elasticsearch.env.ShardLockObtainFailedException.class);
         ids.put(148, org.elasticsearch.common.xcontent.NamedXContentRegistry.UnknownNamedObjectException.class);
         ids.put(149, MultiBucketConsumerService.TooManyBucketsException.class);
-        ids.put(150, org.elasticsearch.indices.IndexOpenException.class);
 
         Map<Class<? extends ElasticsearchException>, Integer> reverse = new HashMap<>();
         for (Map.Entry<Integer, Class<? extends ElasticsearchException>> entry : ids.entrySet()) {

server/src/test/java/org/elasticsearch/ExceptionSerializationTests.java

@@ -38,7 +38,6 @@
 import org.elasticsearch.env.NodeEnvironment;
 import org.elasticsearch.index.IndexNotFoundException;
 import org.elasticsearch.index.query.RangeQueryBuilder;
-import org.elasticsearch.indices.IndexOpenException;
 import org.elasticsearch.test.ESIntegTestCase;
 import org.elasticsearch.test.ESIntegTestCase.ClusterScope;
 import org.elasticsearch.test.ESIntegTestCase.Scope;
@@ -392,8 +391,8 @@ public Settings onNodeStopped(String nodeName) throws Exception {
         assertThat(stateAfterRestart.getMetaData().index(metaData.getIndex()).getState(), equalTo(IndexMetaData.State.CLOSE));
 
         // try to open the index
-        final ElasticsearchException e =
-                expectThrows(IndexOpenException.class, () -> client().admin().indices().prepareOpen("test").get());
+        final Exception e =
+                expectThrows(IllegalArgumentException.class, () -> client().admin().indices().prepareOpen("test").get());
         assertThat(e, hasToString(containsString("Failed to verify index " + metaData.getIndex())));
         assertThat(e, hasToString(containsString("unknown setting [index.foo]")));
     }

server/src/test/java/org/elasticsearch/action/admin/indices/create/CreateIndexIT.java

@@ -43,7 +43,6 @@
 import org.elasticsearch.discovery.zen.ElectMasterService;
 import org.elasticsearch.env.NodeEnvironment;
 import org.elasticsearch.indices.IndexClosedException;
-import org.elasticsearch.indices.IndexOpenException;
 import org.elasticsearch.node.Node;
 import org.elasticsearch.test.ESIntegTestCase;
 import org.elasticsearch.test.ESIntegTestCase.ClusterScope;
@@ -418,7 +417,7 @@ public void testDoNotOpenIndexWithUnknownOrAchivedSettings() throws Exception {
         assertEquals("true", state.getMetaData().index(metaData.getIndex()).getSettings().get("archived.index.unknown.setting"));
 
         // try to open it with the archived setting - fail again with IndexOpenException
-        ElasticsearchException ex = expectThrows(IndexOpenException.class, () -> client().admin().indices().prepareOpen("test").get());
+        Exception ex = expectThrows(IllegalArgumentException.class, () -> client().admin().indices().prepareOpen("test").get());
         assertThat(ex.getMessage(), startsWith("Failed to open index! Failed to verify index " + metaData.getIndex()));
         assertThat(ex.getMessage(), containsString("unknown setting [archived.index.unknown.setting]"));
 
@@ -480,7 +479,7 @@ public void testRecoverMissingAnalyzer() throws Exception {
         assertEquals(IndexMetaData.State.CLOSE, state.getMetaData().index(metaData.getIndex()).getState());
 
         // try to open it with the broken setting - fail again!
-        ElasticsearchException ex = expectThrows(IndexOpenException.class, () -> client().admin().indices().prepareOpen("test").get());
+        Exception ex = expectThrows(IllegalArgumentException.class, () -> client().admin().indices().prepareOpen("test").get());
         assertThat(ex.getMessage(), startsWith("Failed to open index! Failed to verify index " + metaData.getIndex()));
         assertThat(ex.getMessage(), containsString("analyzer [test] not found for field [field1]"));
     }