Enable deprecated-pragma by default.

mbyrnepr2 · mbyrnepr2 · commit 171be5ed3f3b · 2023-06-01T20:06:47.000+02:00
Closes pylint-dev#8725
diff --git a/doc/whatsnew/fragments/8725.bugfix b/doc/whatsnew/fragments/8725.bugfix
@@ -0,0 +1,3 @@
+Enable ``deprecated-pragma`` by default.
+
+Closes #8725
diff --git a/pylint/lint/message_state_handler.py b/pylint/lint/message_state_handler.py
@@ -388,6 +388,7 @@ def process_tokens(self, tokens: list[tokenize.TokenInfo]) -> None:
                                 "deprecated-pragma",
                                 line=start[0],
                                 args=("disable=all", "skip-file"),
+                                confidence=HIGH,
                             )
                             self.linter.add_message("file-ignored", line=start[0])
                             self._ignore_file = True
diff --git a/pylint/lint/pylinter.py b/pylint/lint/pylinter.py
@@ -196,7 +196,6 @@ def _load_reporter_by_class(reporter_class: str) -> type[BaseReporter]:
         {
             "old_names": [("I0014", "deprecated-disable-all")],
             "scope": WarningScope.LINE,
-            "default_enabled": False,
         },
     ),
     "E0001": (
diff --git a/tests/functional/d/deprecated/deprecated_pragma.py b/tests/functional/d/deprecated/deprecated_pragma.py
@@ -0,0 +1 @@
+# pylint: disable=all  # [deprecated-pragma]
diff --git a/tests/functional/d/deprecated/deprecated_pragma.txt b/tests/functional/d/deprecated/deprecated_pragma.txt
@@ -0,0 +1 @@
+deprecated-pragma:1:0:None:None::"Pragma ""disable=all"" is deprecated, use ""skip-file"" instead":HIGH

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+Enable ``deprecated-pragma`` by default.
	`2`	`+`
	`3`	`+Closes #8725`
Original file line number	Diff line number	Diff line change
`@@ -388,6 +388,7 @@ def process_tokens(self, tokens: list[tokenize.TokenInfo]) -> None:`
`388`	`388`	`"deprecated-pragma",`
`389`	`389`	`line=start[0],`
`390`	`390`	`args=("disable=all", "skip-file"),`
	`391`	`+ confidence=HIGH,`
`391`	`392`	`)`
`392`	`393`	`self.linter.add_message("file-ignored", line=start[0])`
`393`	`394`	`self._ignore_file = True`
Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,6 @@ def _load_reporter_by_class(reporter_class: str) -> type[BaseReporter]:`
`196`	`196`	`{`
`197`	`197`	`"old_names": [("I0014", "deprecated-disable-all")],`
`198`	`198`	`"scope": WarningScope.LINE,`
`199`		`- "default_enabled": False,`
`200`	`199`	`},`
`201`	`200`	`),`
`202`	`201`	`"E0001": (`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# pylint: disable=all # [deprecated-pragma]`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+deprecated-pragma:1:0:None:None::"Pragma ""disable=all"" is deprecated, use ""skip-file"" instead":HIGH`