Merge #1653

1653: Make documentation compatible with node 16 r=maryamsulemani97 a=bidoubiwa

fixes #1323

This PR becomes important as node 14 entered maintenance mode and will soon be EOL. Node 16 is now the current version and soon enough node 18 will takes its place. 

The documentation was not compatible with node 16 because it used [`vuepress-plugin-element-tabs`](https://github.com/Kaifun/vuepress-plugin-tabs) that itself used [`node-sass`](https://www.npmjs.com/package/node-sass) that is deprecated.

I created a fork of that same plugin [``@bidoubiwa/vuepress-plugin-elements-tabs`](https://github.com/bidoubiwa/vuepress-plugin-element-tabs)` that upgraded `node-sass` to `sass`. Which makes it compatible with node 16. 

This PR also upgrades all `actions/setup-node` from v2 to v3 as v3 uses by default node v16.

A good consideration would also be to upgrade netlify node version to 16 if it is possible. 

Co-authored-by: Charlotte Vermandel <[email protected]>
Co-authored-by: cvermand <[email protected]>

Author: bors[bot]

Diff for: .github/workflows/check-links.yml

@@ -10,38 +10,42 @@ on:
       - master
 
 jobs:
+  check-builds:
+    runs-on: ubuntu-20.04
+    strategy:
+      fail-fast: false
+      matrix:
+        node: ["14", "16"]
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node }}
+          cache: "yarn"
+          cache-dependency-path: yarn.lock
+      - run: yarn install
+      - run: yarn build
+
   check-links:
     runs-on: ubuntu-20.04
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
         with:
           node-version: 14
-          registry-url: https://registry.npmjs.org/
-      - name: Cache dependencies
-        uses: actions/cache@v2
-        with:
-          path: ~/.npm
-          key: ${{ runner.os }}-node-${{ hashFiles('**/yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-node-
+          cache: "yarn"
+          cache-dependency-path: yarn.lock
       - run: yarn install
       - run: yarn check-links
 
   check-style:
     runs-on: ubuntu-20.04
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
         with:
           node-version: 14
-          registry-url: https://registry.npmjs.org/
-      - name: Cache dependencies
-        uses: actions/cache@v2
-        with:
-          path: ~/.npm
-          key: ${{ runner.os }}-node-${{ hashFiles('**/yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-node-
+          cache: "yarn"
+          cache-dependency-path: yarn.lock
       - run: yarn install
       - run: yarn style

Diff for: .github/workflows/gh-pages-scraping.yml

@@ -10,11 +10,12 @@ jobs:
     runs-on: ubuntu-20.04
 
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
         with:
           node-version: 14
-          registry-url: https://registry.npmjs.org/
+          cache: "yarn"
+          cache-dependency-path: yarn.lock
       - name: Publish
         uses: netlify/actions/build@master
         env:
@@ -27,11 +28,7 @@ jobs:
     needs: build-deploy
     runs-on: ubuntu-20.04
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
-        with:
-          node-version: 14
-          registry-url: https://registry.npmjs.org/
+      - uses: actions/checkout@v3
       - name: Run docs-scraper
         env:
           HOST_URL: ${{ secrets.MEILISEARCH_HOST_URL }}

Diff for: .vuepress/config.js

@@ -358,7 +358,7 @@ module.exports = {
     'img-lazy',
     // Because colors can not be set through the settings of the plugin
     // Change are done in .vuepress/styles/palette.styl
-    'vuepress-plugin-element-tabs',
+    '@bidoubiwa/vuepress-plugin-element-tabs',
     ['vuepress-plugin-container', { type: 'note' }],
     [require('./config-path-checker')],
     [require('./custom-markdown-rules')],

Diff for: README.markdown

@@ -24,7 +24,7 @@ If this happens to you and you think there has been some mistake, please let us
 
 ### Requirements
 
-- Node version >= v10 and < v15
+- Node version >= v14 and <= v16
 
 ### Installing & Running
 

Diff for: package.json

@@ -31,10 +31,10 @@
   "author": "tpayet",
   "license": "MIT",
   "dependencies": {
+    "@bidoubiwa/vuepress-plugin-element-tabs": "^0.2.9",
     "vuepress": "^1.8.2",
     "vuepress-plugin-code-copy": "^1.0.6",
     "vuepress-plugin-container": "^2.1.5",
-    "vuepress-plugin-element-tabs": "^0.2.8",
     "vuepress-plugin-img-lazy": "^1.0.4",
     "vuepress-plugin-meilisearch": "0.12.1",
     "vuepress-plugin-seo": "^0.1.4",
@@ -44,7 +44,7 @@
     "vuex": "^3.6.2"
   },
   "engines": {
-    "node": ">=12 <15"
+    "node": ">=12 <=16"
   },
   "resolutions": {
     "vuepress-plugin-check-md/check-md": "https://github.com/bidoubiwa/check-md#add_ignore_pattern"