-
Notifications
You must be signed in to change notification settings - Fork 261
Netlify deploys sometimes use readme.md
as the docs home
#1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
According to an old Vuepress issue, there are cases when a site uses This does sound like what's happening to us. The suggested fix in the thread is to rename |
/learn/contributing/contributing_to_docs.md
as the docs homereadme.md
as the docs home
@bidoubiwa suggested this bug might be related to PR #965; more specifically, on line 54 of That seems like a fairly basic error that vuepress should have accounted for, but it's worth looking into if the above suggested quickfix doesn't solve the issue (change the readme extension). |
There is a solution that might prevent us for ever serving a build that uses Using the cypress netlify plugin we can cancel the publish when elements of the landing are not appearing on the final build. it('Contains Welcome message', () => {
cy.contains(
"Welcome to the MeiliSearch documentation. Here you'll find everything you need to learn and create with our lightning fast search engine."
)
}) |
This has happened twice so far:
In all cases, triggering a re-build (manually via Netlify's web interface or automatically via e.g. a new commit in a PR) fixed the issue.
The first instance of the issue was recorded shortly after we started using Bors in this repo. We are not sure whether this is just a coincidence or if the issue is actually connected to Bors.
Comparing Netlify logs between correct and incorrect deploys doesn't seem to reveal any relevant information: there is a slight variation in the number of generated files, but as far as we can see this type of variation is normal and does not influence the deploy in any way.
The text was updated successfully, but these errors were encountered: