Skip to content

feat: Cortex model importing #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cloudherder opened this issue Sep 1, 2024 · 5 comments
Closed

feat: Cortex model importing #1058

cloudherder opened this issue Sep 1, 2024 · 5 comments
Assignees
Labels
category: model management Model pull, yaml, model state P1: important Important feature / fix type: feature request A new feature
Milestone

Comments

@cloudherder
Copy link

cloudherder commented Sep 1, 2024

Goal

  • Cortex can import a model that is already on the user's computer
  • Question: by symlink or cp?
  • CLI: cortex model import <path>, but how do we specify engine etc? (or scope to only GGUF?)

Original Post

Problem
Even though I already have a GGUF model, I still need to re-pull the model, which seems not very friendly. Could Cortex add a feature to import models?

It would be even better if the models command could directly load a model file, although loading a model not listed in the model ID list might cause an error, but this way users can try using more models.

@cloudherder cloudherder added the type: feature request A new feature label Sep 1, 2024
@imtuyethan imtuyethan moved this to Icebox in Menlo Sep 2, 2024
@freelerobot freelerobot added the P1: important Important feature / fix label Sep 4, 2024
@freelerobot freelerobot changed the title feat: Could Cortex add a feature to import models? and can it directly load a model file? feat: import local model binary Sep 6, 2024
@freelerobot freelerobot added the category: model management Model pull, yaml, model state label Sep 6, 2024
@dan-menlo dan-menlo changed the title feat: import local model binary feat: Cortex model importing for llama.cpp Sep 8, 2024
@dan-menlo dan-menlo changed the title feat: Cortex model importing for llama.cpp feat: Cortex model importing Sep 8, 2024
@dan-menlo dan-menlo changed the title feat: Cortex model importing feat: Cortex model importing via symlink Sep 8, 2024
@dan-menlo
Copy link
Contributor

@cloudherder This is an important feature. We will be expanding this to solve for generic model importing in cortex.cpp.

@dan-menlo dan-menlo changed the title feat: Cortex model importing via symlink feat: Cortex model importing Sep 8, 2024
@cloudherder
Copy link
Author

@cloudherder This is an important feature. We will be expanding this to solve for generic model importing in cortex.cpp.

I am honored to receive your affirmative response. I will continue to monitor the development of cortex.cpp.

@dan-menlo
Copy link
Contributor

@namchuai @nguyenhoangthuan99 Are we doing this in Sprint 21? (I will move it to Sprint 22 otherwise)

@nguyenhoangthuan99
Copy link
Contributor

The import command is supported with this PR #1248

@dan-menlo dan-menlo moved this from Icebox to Review + QA in Menlo Oct 13, 2024
@dan-menlo dan-menlo moved this from Review + QA to Completed in Menlo Oct 13, 2024
@dan-menlo
Copy link
Contributor

Closing

@gabrielle-ong gabrielle-ong added this to the v1.0.1 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: model management Model pull, yaml, model state P1: important Important feature / fix type: feature request A new feature
Projects
Archived in project
Development

No branches or pull requests

6 participants