Skip to content

feat: cortex engines get <engine_id> #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #1072
vansangpfiev opened this issue Aug 22, 2024 · 3 comments
Closed
Tracked by #1072

feat: cortex engines get <engine_id> #1073

vansangpfiev opened this issue Aug 22, 2024 · 3 comments
Assignees
Labels
category: engine management Related to engine abstraction P1: important Important feature / fix
Milestone

Comments

@vansangpfiev
Copy link
Contributor

vansangpfiev commented Aug 22, 2024

No description provided.

@dan-menlo dan-menlo changed the title cortex engines get cortex engines <engine> install Aug 29, 2024
@namchuai
Copy link
Contributor

I will change this name back to cortex engines get because its purpose is to get an engine status (ready, not ready, etc.)
For engines <name> install, please go to #1072

@namchuai namchuai changed the title cortex engines <engine> install cortex engines get Aug 29, 2024
@imtuyethan imtuyethan transferred this issue from another repository Sep 2, 2024
@freelerobot freelerobot changed the title cortex engines get cortex engines get <engine_id> Sep 6, 2024
@freelerobot freelerobot added the P1: important Important feature / fix label Sep 6, 2024
@freelerobot freelerobot changed the title cortex engines get <engine_id> feat: cortex engines get <engine_id> Sep 6, 2024
@freelerobot freelerobot changed the title feat: cortex engines get <engine_id> feat: cortex engines get <engine_id> Sep 6, 2024
@dan-menlo dan-menlo added the category: engine management Related to engine abstraction label Sep 6, 2024
@namchuai
Copy link
Contributor

namchuai commented Sep 9, 2024

The PR for this is merged and I think we can move this ticket to QA.

Image

HTTP API:

curl --location 'localhost:3928/engines/cortex.llamacpp'

Response:

{
    "description": "This extension enables chat completion API calls using the LlamaCPP engine",
    "name": "cortex.llamacpp",
    "productName": "LlamaCPP Inference Engine",
    "status": "not_initialized",
    "version": "0.0.1"
}

@gabrielle-ong
Copy link
Contributor

QA: cortex engines get <engine id> works
✅ Mac
✅ Windows
✅ Ubuntu

Linked to follow-up open issue #1168 - to have consistency in the names & IDs
eg cortex engines get cortex.llamacpp when the engines list table shows Name = llama.cpp

Mac
Image

Windows:
Image

Ubuntu:
Image

@gabrielle-ong gabrielle-ong added this to the v1.0.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: engine management Related to engine abstraction P1: important Important feature / fix
Projects
Archived in project
Development

No branches or pull requests

5 participants