Skip to content

epic: cortex models pull <ID_or_URL> #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks done
Tracked by #1080
Van-QA opened this issue Aug 16, 2024 · 6 comments
Closed
8 tasks done
Tracked by #1080

epic: cortex models pull <ID_or_URL> #1077

Van-QA opened this issue Aug 16, 2024 · 6 comments
Assignees
Labels
category: model management Model pull, yaml, model state type: epic A major feature or initiative

Comments

@Van-QA
Copy link
Contributor

Van-QA commented Aug 16, 2024

Goal

  • Pull from Jan's curated models
  • Pull from Huggingface based on URL

Tasklist

Bugs

Out-of-scope

@namchuai
Copy link
Contributor

Updating a flow chart on fetch and downloading model from Hugging Face

Screenshot 2024-08-21 at 07 46 51

@namchuai
Copy link
Contributor

After downloading model, should we automatically check for engine and init engine (if neccessary)?

Screenshot 2024-08-21 at 07 47 56

@imtuyethan imtuyethan transferred this issue from another repository Sep 2, 2024
@freelerobot freelerobot changed the title Download models feat: Download models Sep 6, 2024
@freelerobot freelerobot changed the title feat: Download models feat: cortex models pull <> Sep 6, 2024
@freelerobot freelerobot changed the title feat: cortex models pull <> feat: cortex models pull <ID_or_URL> Sep 6, 2024
@freelerobot freelerobot added the category: model management Model pull, yaml, model state label Sep 6, 2024
@dan-menlo
Copy link
Contributor

@namchuai Can I check, does your implementation of cortex pull cover the case of a Huggingface URL to a specific GGUF model?

cortex pull https://huggingface.co/BafS/gemma-2-2b-it-Q4_K_M-GGUF/blob/main/gemma-2-2b-it-q4_k_m.gguf

@dan-menlo
Copy link
Contributor

dan-menlo commented Sep 6, 2024

After downloading model, should we automatically check for engine and init engine (if neccessary)?

@namchuai From a UX perspective, I think we should not automatically init a model:

  • We should show useful feedback to pre-empt problems
  • e.g. "To run this model, you will need to initialize the TensorRT-LLM engine, i.e. cortex engines init tensorrt-llm

@namchuai
Copy link
Contributor

namchuai commented Sep 6, 2024

@namchuai Can I check, does your implementation of cortex pull cover the case of a Huggingface URL to a specific GGUF model?

cortex pull https://huggingface.co/BafS/gemma-2-2b-it-Q4_K_M-GGUF/blob/main/gemma-2-2b-it-q4_k_m.gguf

Currently, we are not cover this case. This will be supported in upcoming release, I think.

@gabrielle-ong
Copy link
Contributor

Marking as complete! 🎉

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Menlo Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: model management Model pull, yaml, model state type: epic A major feature or initiative
Projects
Archived in project
Development

No branches or pull requests

5 participants