Skip to content

bug: TensorRT-LLM frequency_penalty Parameter in model.yml Only Functions Correctly with Value 1, Produces Gibberish for other values #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Van-QA opened this issue Jul 18, 2024 · 3 comments
Assignees
Labels
engine: tensorrt-llm wontfix This will not be worked on

Comments

@Van-QA
Copy link
Contributor

Van-QA commented Jul 18, 2024

Describe the bug
The frequency_penalty parameter in the model.yml file only functions correctly when its value is set to 1. The model generates gibberish responses when the value is set to 0 or 0.5.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the model.yml file.
  2. Set the frequency_penalty parameter to 0.
  3. Run the model and observe the responses.
  4. Repeat steps 2 and 3 with frequency_penalty set to 0.5.
  5. Set the frequency_penalty parameter to 1 and observe the responses.

Expected behavior
The model should produce coherent and contextually appropriate responses regardless of the frequency_penalty value, whether set to 0, 0.5, or 1.

Screenshots
image
image

Additional context
This issue affects the consistency and reliability of the model's output, impacting its usability in applications that rely on varied frequency_penalty settings for diverse response generation.

@Van-QA Van-QA added the type: bug Something isn't working label Jul 18, 2024
@Van-QA Van-QA transferred this issue from menloresearch/cortex.cpp Jul 18, 2024
@imtuyethan
Copy link
Contributor

is this bug urgent?

@dan-menlo dan-menlo transferred this issue from menloresearch/cortex.tensorrt-llm Sep 6, 2024
@dan-menlo dan-menlo added the category: model management Model pull, yaml, model state label Sep 6, 2024
@vansangpfiev
Copy link
Contributor

Moved to sprint 24 to handle tensorrt-llm engine

@dan-menlo dan-menlo changed the title bug: frequency_penalty Parameter in model.yml Only Functions Correctly with Value 1, Produces Gibberish for other values bug: TensorRT-LLM frequency_penalty Parameter in model.yml Only Functions Correctly with Value 1, Produces Gibberish for other values Oct 31, 2024
@gabrielle-ong
Copy link
Contributor

Deprecated due to TensorRT-LLM not supporting Desktop
Parent issue: #1742

@github-project-automation github-project-automation bot moved this from Scheduled to Review + QA in Menlo Nov 28, 2024
@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Menlo Nov 28, 2024
@gabrielle-ong gabrielle-ong added wontfix This will not be worked on engine: tensorrt-llm and removed type: bug Something isn't working category: model management Model pull, yaml, model state labels Nov 28, 2024
@gabrielle-ong gabrielle-ong moved this from Completed to Discontinued in Menlo Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine: tensorrt-llm wontfix This will not be worked on
Projects
Archived in project
Development

No branches or pull requests

6 participants