Skip to content

bug: running cortex update on latest version should gracefully inform "already up to date" #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 6 tasks
Tracked by #1087
gabrielle-ong opened this issue Sep 20, 2024 · 3 comments
Closed
2 of 6 tasks
Tracked by #1087

bug: running cortex update on latest version should gracefully inform "already up to date" #1278

gabrielle-ong opened this issue Sep 20, 2024 · 3 comments
Assignees
@vansangpfiev
Labels
P2: enhancement low impact on functionality type: bug Something isn't working
Milestone
v1.0.0

Comments

@gabrielle-ong
Copy link
Contributor

Cortex version

0.5.0-74

Describe the Bug

  1. cortex update to latest version
  2. cortex update - downloads latest version again

I expect it should check: if already on the latest version, respond
cortex is up to date

Steps to Reproduce

No response

Screenshots / Logs

Screenshot 2024-09-20 at 2 59 11 PM

What is your OS?

  • MacOS
  • Windows
  • Linux

What engine are you running?

  • cortex.llamacpp (default)
  • cortex.tensorrt-llm (Nvidia GPUs)
  • cortex.onnx (NPUs, DirectML)
@gabrielle-ong gabrielle-ong added the type: bug Something isn't working label Sep 20, 2024
@dan-menlo dan-menlo added this to Menlo Sep 20, 2024
@freelerobot
Copy link
Contributor

hm yeah this is a good catch / edge case

@freelerobot freelerobot added the P2: enhancement low impact on functionality label Sep 21, 2024
@freelerobot freelerobot moved this to Planning in Menlo Sep 21, 2024
@freelerobot freelerobot changed the title bug: cortex update downloads even through it is on the latest version bug: running cortex update on latest version should gracefully inform "already up to date" Sep 21, 2024
@vansangpfiev vansangpfiev moved this from Planning to In Progress in Menlo Sep 25, 2024
@vansangpfiev vansangpfiev mentioned this issue Sep 25, 2024
Merged
3 tasks
@vansangpfiev
Copy link
Contributor

Resolved on cortex v0.5.0-114
image

@freelerobot
Copy link
Contributor

confirm resolved

@github-project-automation github-project-automation bot moved this from In Progress to Completed in Menlo Sep 26, 2024
@gabrielle-ong gabrielle-ong added this to the v1.0.0 milestone Oct 3, 2024
@gabrielle-ong gabrielle-ong mentioned this issue Oct 3, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vansangpfiev vansangpfiev

Labels
P2: enhancement low impact on functionality type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
v1.0.0
Development

No branches or pull requests
3 participants
@vansangpfiev @gabrielle-ong @freelerobot