Skip to content

idea: [DownloadEvent] Adding event queue to process event asynchronously #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1242
namchuai opened this issue Oct 3, 2024 · 2 comments · Fixed by #1365
Closed
Tracked by #1242

idea: [DownloadEvent] Adding event queue to process event asynchronously #1394

namchuai opened this issue Oct 3, 2024 · 2 comments · Fixed by #1365
Assignees
@namchuai
Milestone
v1.0.1

Comments

@namchuai
Copy link
Contributor

namchuai commented Oct 3, 2024

Problem Statement

If we write a simple callback, the thread of event emitter will have to wait for the event listener to finished consuming events. This might cause hang.

Feature Idea

Using eventpp package to have an EventQueue which acts as a buffer in between EventEmitter and EventListener
@namchuai namchuai self-assigned this Oct 3, 2024
This was referenced Oct 3, 2024
Closed
Merged
@namchuai namchuai added this to Menlo Oct 3, 2024
@github-project-automation github-project-automation bot moved this to Investigating in Menlo Oct 3, 2024
@namchuai namchuai moved this from Investigating to In Progress in Menlo Oct 3, 2024
@namchuai namchuai moved this from In Review to Review + QA in Menlo Oct 16, 2024
@namchuai
Copy link
Contributor Author

PR merged, closed!

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Menlo Oct 18, 2024
@gabrielle-ong
Copy link
Contributor

QAing in overall #1242, marking as complete

@gabrielle-ong gabrielle-ong added this to the v1.0.1 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namchuai namchuai

Labels
None yet
Projects
Menlo
Archived in project
Milestone
v1.0.1
Development

Successfully merging a pull request may close this issue.

chore: consolidate download service menloresearch/cortex.cpp
2 participants
@namchuai @gabrielle-ong