Check metric names

Author: ecekyn

model/model.go

@@ -514,3 +514,7 @@ type GetAttributeKeysResponse struct {
 	// The attribute values
 	Attributes []string `json:"attributes"`
 }
+
+type GetMetricNamesResponse struct {
+	MetricNames []string `json:"metrics"`
+}

tools/get_attribute_keys.go

@@ -8,6 +8,9 @@ import (
 	mcpgolang "github.com/metoro-io/mcp-golang"
 	"github.com/metoro-io/metoro-mcp-server/model"
 	"github.com/metoro-io/metoro-mcp-server/utils"
+	"slices"
+	"strings"
+	"time"
 )
 
 type GetAttributeKeysHandlerArgs struct {
@@ -26,6 +29,12 @@ func GetAttributeKeysHandler(ctx context.Context, arguments GetAttributeKeysHand
 		if arguments.MetricName == "" {
 			return nil, fmt.Errorf("metricName is required when type is 'metric'")
 		}
+
+		// Check whether the metric is valid. If not, return an error.
+		err = CheckMetric(ctx, arguments.MetricName)
+		if err != nil {
+			return nil, err
+		}
 	}
 
 	metricAttr := model.GetMetricAttributesRequest{
@@ -52,3 +61,27 @@ func GetAttributeKeysHandler(ctx context.Context, arguments GetAttributeKeysHand
 
 	return mcpgolang.NewToolResponse(mcpgolang.NewTextContent(fmt.Sprintf("%s", string(resp)))), nil
 }
+
+func CheckMetric(ctx context.Context, metricName string) error {
+	now := time.Now()
+	hourAgo := now.Add(-30 * time.Minute)
+	request := model.FuzzyMetricsRequest{
+		StartTime:        hourAgo.Unix(),
+		EndTime:          now.Unix(),
+		MetricFuzzyMatch: "", // This will return all the metric names.
+	}
+	metricNamesResp, err := getMetricNamesMetoroCall(ctx, request)
+
+	metricNames := model.GetMetricNamesResponse{}
+	err = json.Unmarshal(metricNamesResp, &metricNames)
+	if err != nil {
+		return fmt.Errorf("error unmarshaling response: %v", err)
+	}
+
+	metricNamesStr := strings.Join(metricNames.MetricNames, ", ")
+	if !slices.Contains(metricNames.MetricNames, metricName) {
+		return fmt.Errorf("metricName '%s' is not valid. Valid metric names are: %s", metricName, metricNamesStr)
+	}
+
+	return nil
+}

tools/get_multi_metric.go

@@ -42,7 +42,7 @@ func GetMultiMetricHandler(ctx context.Context, arguments GetMultiMetricHandlerA
 		return nil, fmt.Errorf("error calculating time range: %v", err)
 	}
 
-	err = checkTimeseriesAttributes(ctx, arguments.Timeseries, startTime, endTime)
+	err = checkTimeseries(ctx, arguments.Timeseries, startTime, endTime)
 	if err != nil {
 		return nil, err
 	}
@@ -188,9 +188,13 @@ func CheckAttributes(ctx context.Context, requestType model.MetricType, filters
 	return nil
 }
 
-func checkTimeseriesAttributes(ctx context.Context, timeseries []SingleMetricRequest, startTime, endTime int64) error {
+func checkTimeseries(ctx context.Context, timeseries []SingleMetricRequest, startTime, endTime int64) error {
 	for _, ts := range timeseries {
-		err := CheckAttributes(ctx, ts.Type, ts.Filters, ts.ExcludeFilters, ts.Splits, &model.GetMetricAttributesRequest{
+		err := CheckMetric(ctx, ts.MetricName)
+		if err != nil {
+			return err
+		}
+		err = CheckAttributes(ctx, ts.Type, ts.Filters, ts.ExcludeFilters, ts.Splits, &model.GetMetricAttributesRequest{
 			StartTime:  startTime,
 			EndTime:    endTime,
 			MetricName: ts.MetricName,