Skip to content

Commit 2aeeed0

Browse files
committed
service worker: skipWaiting() should resolve after activation.
See w3c/ServiceWorker#1187 and w3c/ServiceWorker#1327.
1 parent 0007ac4 commit 2aeeed0

File tree

1 file changed

+2
-14
lines changed

1 file changed

+2
-14
lines changed

service-workers/service-worker/resources/skip-waiting-installed-worker.js

+2-14
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,3 @@
1-
var saw_activate_event = false
2-
3-
self.addEventListener('activate', function() {
4-
saw_activate_event = true;
5-
});
6-
71
self.addEventListener('message', function(event) {
82
var port = event.data.port;
93
event.waitUntil(self.skipWaiting()
@@ -13,15 +7,9 @@ self.addEventListener('message', function(event) {
137
return;
148
}
159

16-
if (!saw_activate_event) {
17-
port.postMessage(
18-
'FAIL: Promise should be resolved after activate event is dispatched');
19-
return;
20-
}
21-
22-
if (self.registration.active.state !== 'activating') {
10+
if (self.registration.active.state !== 'activated') {
2311
port.postMessage(
24-
'FAITL: Promise should be resolved before ServiceWorker#state is set to activated');
12+
'FAIL: Promise should be resolved after ServiceWorker#state is set to activated');
2513
return;
2614
}
2715

0 commit comments

Comments
 (0)