Merge pull request #309 from ilejn/memberid_leak

mfontanini · web-flow · commit ec1c7f3a00bd · 2024-01-24T11:33:50.000-08:00
get_member_id leak fix
diff --git a/src/consumer.cpp b/src/consumer.cpp
@@ -240,7 +240,10 @@ TopicPartitionList Consumer::get_assignment() const {
 }
 
 string Consumer::get_member_id() const {
-    return rd_kafka_memberid(get_handle());
+    char* memberid_ptr = rd_kafka_memberid(get_handle());
+    string memberid_string = memberid_ptr;
+    rd_kafka_mem_free(nullptr, memberid_ptr);
+    return memberid_string;
 }
 
 const Consumer::AssignmentCallback& Consumer::get_assignment_callback() const {

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,10 @@ TopicPartitionList Consumer::get_assignment() const {`
`240`	`240`	`}`
`241`	`241`
`242`	`242`	`string Consumer::get_member_id() const {`
`243`		`- return rd_kafka_memberid(get_handle());`
	`243`	`+ char* memberid_ptr = rd_kafka_memberid(get_handle());`
	`244`	`+ string memberid_string = memberid_ptr;`
	`245`	`+ rd_kafka_mem_free(nullptr, memberid_ptr);`
	`246`	`+ return memberid_string;`
`244`	`247`	`}`
`245`	`248`
`246`	`249`	`const Consumer::AssignmentCallback& Consumer::get_assignment_callback() const {`