Skip to content

Commit d4b2731

Browse files
committed
Fix bean names in Brave and Otel auto-configuration
See spring-projectsgh-30156
1 parent 2185372 commit d4b2731

File tree

2 files changed

+14
-11
lines changed

2 files changed

+14
-11
lines changed

Diff for: spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/tracing/BraveAutoConfiguration.java

+5-4
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ public class BraveAutoConfiguration {
6161

6262
@Bean
6363
@ConditionalOnMissingBean
64-
Tracing tracing(Environment environment, List<SpanHandler> spanHandlers, List<TracingCustomizer> tracingCustomizers,
64+
Tracing braveTracing(Environment environment, List<SpanHandler> spanHandlers,
65+
List<TracingCustomizer> tracingCustomizers,
6566
CurrentTraceContext currentTraceContext, Factory propagationFactory, Sampler sampler) {
6667
String applicationName = environment.getProperty("spring.application.name");
6768
Builder builder = Tracing.newBuilder().currentTraceContext(currentTraceContext)
@@ -84,7 +85,7 @@ brave.Tracer braveTracer(Tracing tracing) {
8485

8586
@Bean
8687
@ConditionalOnMissingBean
87-
CurrentTraceContext currentTraceContext(List<CurrentTraceContext.ScopeDecorator> scopeDecorators,
88+
CurrentTraceContext braveCurrentTraceContext(List<CurrentTraceContext.ScopeDecorator> scopeDecorators,
8889
List<CurrentTraceContextCustomizer> currentTraceContextCustomizers) {
8990
ThreadLocalCurrentTraceContext.Builder builder = ThreadLocalCurrentTraceContext.newBuilder();
9091
for (ScopeDecorator scopeDecorator : scopeDecorators) {
@@ -98,14 +99,14 @@ CurrentTraceContext currentTraceContext(List<CurrentTraceContext.ScopeDecorator>
9899

99100
@Bean
100101
@ConditionalOnMissingBean
101-
Factory propagationFactory() {
102+
Factory bravePropagationFactory() {
102103
// TODO MH: Make configurable?
103104
return B3Propagation.newFactoryBuilder().injectFormat(B3Propagation.Format.SINGLE_NO_PARENT).build();
104105
}
105106

106107
@Bean
107108
@ConditionalOnMissingBean
108-
Sampler sampler(TracingProperties properties) {
109+
Sampler braveSampler(TracingProperties properties) {
109110
return Sampler.create(properties.getSampling().getProbability());
110111
}
111112

Diff for: spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/tracing/OpenTelemetryAutoConfiguration.java

+9-7
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ OpenTelemetry openTelemetry(SdkTracerProvider sdkTracerProvider, ContextPropagat
6969

7070
@Bean
7171
@ConditionalOnMissingBean
72-
SdkTracerProvider sdkTracerProvider(List<SpanProcessor> spanProcessors, Sampler sampler) {
72+
SdkTracerProvider otelSdkTracerProvider(List<SpanProcessor> spanProcessors, Sampler sampler) {
7373
SdkTracerProviderBuilder builder = SdkTracerProvider.builder().setSampler(sampler);
7474
for (SpanProcessor spanProcessor : spanProcessors) {
7575
builder.addSpanProcessor(spanProcessor);
@@ -79,22 +79,23 @@ SdkTracerProvider sdkTracerProvider(List<SpanProcessor> spanProcessors, Sampler
7979

8080
@Bean
8181
@ConditionalOnMissingBean
82-
ContextPropagators contextPropagators(List<TextMapPropagator> textMapPropagators) {
82+
ContextPropagators otelContextPropagators(List<TextMapPropagator> textMapPropagators) {
8383
return ContextPropagators.create(TextMapPropagator.composite(textMapPropagators));
8484
}
8585

8686
@Bean
8787
@ConditionalOnMissingBean
88-
Sampler sampler(TracingProperties properties) {
88+
Sampler otelSampler(TracingProperties properties) {
8989
return Sampler.traceIdRatioBased(properties.getSampling().getProbability());
9090
}
9191

9292
@Bean
9393
@ConditionalOnMissingBean
94-
SpanProcessor spanProcessor(List<SpanExporter> spanExporter) {
94+
SpanProcessor otelSpanProcessor(List<SpanExporter> spanExporter) {
9595
return SpanProcessor.composite(spanExporter.stream()
9696
.map(exporter -> BatchSpanProcessor.builder(exporter).build()).collect(Collectors.toSet()));
9797
}
98+
9899
}
99100

100101
@Configuration(proxyBeanMethods = false)
@@ -105,10 +106,11 @@ static class TracerConfiguration {
105106
@Bean
106107
@ConditionalOnMissingBean
107108
@ConditionalOnBean(OpenTelemetry.class)
108-
Tracer tracer(OpenTelemetry openTelemetry) {
109+
Tracer otelTracer(OpenTelemetry openTelemetry) {
109110
// TODO MH: Decide on a name
110111
return openTelemetry.getTracer("org.springframework.boot", SpringBootVersion.getVersion());
111112
}
113+
112114
}
113115

114116
@Configuration(proxyBeanMethods = false)
@@ -119,15 +121,15 @@ static class OpenTelemetryMicrometer {
119121
@Bean
120122
@ConditionalOnMissingBean
121123
@ConditionalOnBean(Tracer.class)
122-
OtelTracer otelTracer(Tracer tracer, EventPublisher eventPublisher,
124+
OtelTracer micrometerOtelTracer(Tracer tracer, EventPublisher eventPublisher,
123125
OtelCurrentTraceContext otelCurrentTraceContext) {
124126
return new OtelTracer(tracer, otelCurrentTraceContext, eventPublisher,
125127
new OtelBaggageManager(otelCurrentTraceContext, List.of(), List.of()));
126128
}
127129

128130
@Bean
129131
@ConditionalOnMissingBean
130-
EventPublisher eventPublisher() {
132+
EventPublisher otelTracerEventPublisher() {
131133
return event -> {
132134
};
133135
}

0 commit comments

Comments
 (0)