Skip to content

Commit e55f64f

Browse files
committed
Clean up auto-configuration dependencies
See spring-projectsgh-30156
1 parent 170879f commit e55f64f

File tree

4 files changed

+6
-11
lines changed

4 files changed

+6
-11
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/tracing/BraveAutoConfiguration.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
import io.micrometer.tracing.brave.bridge.BraveCurrentTraceContext;
3434
import io.micrometer.tracing.brave.bridge.BraveTracer;
3535

36-
import org.springframework.boot.actuate.autoconfigure.tracing.zipkin.ZipkinAutoConfiguration;
3736
import org.springframework.boot.autoconfigure.AutoConfiguration;
3837
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
3938
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
@@ -50,7 +49,7 @@
5049
* @author Moritz Halbritter
5150
* @since 3.0.0
5251
*/
53-
@AutoConfiguration(after = ZipkinAutoConfiguration.class)
52+
@AutoConfiguration
5453
@ConditionalOnClass(brave.Tracer.class)
5554
@EnableConfigurationProperties(TracingProperties.class)
5655
public class BraveAutoConfiguration {

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/tracing/MicrometerTracingAutoConfiguration.java

+1-4
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@
1919
import io.micrometer.tracing.Tracer;
2020
import io.micrometer.tracing.handler.DefaultTracingObservationHandler;
2121

22-
import org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration;
23-
import org.springframework.boot.actuate.autoconfigure.tracing.zipkin.ZipkinAutoConfiguration;
2422
import org.springframework.boot.autoconfigure.AutoConfiguration;
2523
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
2624
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
@@ -34,8 +32,7 @@
3432
* @author Moritz Halbritter
3533
* @since 3.0.0
3634
*/
37-
@AutoConfiguration(before = ObservationAutoConfiguration.class,
38-
after = { ZipkinAutoConfiguration.class, BraveAutoConfiguration.class, OpenTelemetryAutoConfiguration.class })
35+
@AutoConfiguration(after = { BraveAutoConfiguration.class, OpenTelemetryAutoConfiguration.class })
3936
@ConditionalOnClass(Tracer.class)
4037
public class MicrometerTracingAutoConfiguration {
4138

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/tracing/OpenTelemetryAutoConfiguration.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
import io.opentelemetry.sdk.trace.samplers.Sampler;
3737

3838
import org.springframework.boot.SpringBootVersion;
39-
import org.springframework.boot.actuate.autoconfigure.tracing.zipkin.ZipkinAutoConfiguration;
4039
import org.springframework.boot.autoconfigure.AutoConfiguration;
4140
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
4241
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
@@ -53,7 +52,7 @@
5352
* @author Moritz Halbritter
5453
* @since 3.0.0
5554
*/
56-
@AutoConfiguration(after = ZipkinAutoConfiguration.class)
55+
@AutoConfiguration
5756
public class OpenTelemetryAutoConfiguration {
5857

5958
@Configuration(proxyBeanMethods = false)

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/tracing/wavefront/WavefrontAutoConfiguration.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
import io.micrometer.tracing.reporter.wavefront.WavefrontSpanHandler;
3131
import io.opentelemetry.sdk.trace.export.SpanExporter;
3232

33-
import org.springframework.boot.actuate.autoconfigure.tracing.BraveAutoConfiguration;
34-
import org.springframework.boot.actuate.autoconfigure.tracing.OpenTelemetryAutoConfiguration;
33+
import org.springframework.boot.actuate.autoconfigure.metrics.CompositeMeterRegistryAutoConfiguration;
34+
import org.springframework.boot.actuate.autoconfigure.metrics.MetricsAutoConfiguration;
3535
import org.springframework.boot.autoconfigure.AutoConfiguration;
3636
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
3737
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
@@ -48,7 +48,7 @@
4848
*
4949
* @author Moritz Halbritter
5050
*/
51-
@AutoConfiguration(before = { OpenTelemetryAutoConfiguration.class, BraveAutoConfiguration.class })
51+
@AutoConfiguration(after = { MetricsAutoConfiguration.class, CompositeMeterRegistryAutoConfiguration.class })
5252
@EnableConfigurationProperties(WavefrontTracingProperties.class)
5353
@ConditionalOnClass(WavefrontSender.class)
5454
class WavefrontAutoConfiguration {

0 commit comments

Comments
 (0)