Skip to content

Commit c5eba79

Browse files
daleesmheler
authored andcommitted
Support k8s 1.26: remove logtostderr
klog args have been removed from kubernetes in 1.26, and deprecated since 1.23. kubernetes/kubernetes#112120 The argument --logtostderr has defaulted to true for a long time, so this removal on older versions should have no impact. Change-Id: I64f934a9bbc39c5e054d8a83b3f6edee061469e6
1 parent d607121 commit c5eba79

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-master.sh

+5-6
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ fi
4949
KUBE_MASTER_URI="https://127.0.0.1:$KUBE_API_PORT"
5050
mkdir -p /srv/magnum/kubernetes/
5151
cat > /etc/kubernetes/config <<EOF
52-
KUBE_LOGTOSTDERR="--logtostderr=true"
5352
KUBE_LOG_LEVEL="--v=3"
5453
EOF
5554
cat > /etc/kubernetes/kubelet <<EOF
@@ -94,7 +93,7 @@ ExecStart=/bin/bash -c '/usr/bin/podman run --name kube-apiserver \\
9493
--volume /etc/pki/tls/certs:/usr/share/ca-certificates:ro \\
9594
\${CONTAINER_INFRA_PREFIX:-\${HYPERKUBE_PREFIX}}hyperkube:\${KUBE_TAG} \\
9695
kube-apiserver \\
97-
\$KUBE_LOGTOSTDERR \$KUBE_LOG_LEVEL \$KUBE_ETCD_SERVERS \$KUBE_API_ADDRESS \$KUBELET_PORT \$KUBE_SERVICE_ADDRESSES \$KUBE_ADMISSION_CONTROL \$KUBE_API_ARGS'
96+
\$KUBE_LOG_LEVEL \$KUBE_ETCD_SERVERS \$KUBE_API_ADDRESS \$KUBELET_PORT \$KUBE_SERVICE_ADDRESSES \$KUBE_ADMISSION_CONTROL \$KUBE_API_ARGS'
9897
ExecStop=-/usr/bin/podman stop kube-apiserver
9998
Delegate=yes
10099
Restart=always
@@ -124,7 +123,7 @@ ExecStart=/bin/bash -c '/usr/bin/podman run --name kube-controller-manager \\
124123
\${CONTAINER_INFRA_PREFIX:-\${HYPERKUBE_PREFIX}}hyperkube:\${KUBE_TAG} \\
125124
kube-controller-manager \\
126125
--secure-port=0 \\
127-
\$KUBE_LOGTOSTDERR \$KUBE_LOG_LEVEL \$KUBE_MASTER \$KUBE_CONTROLLER_MANAGER_ARGS'
126+
\$KUBE_LOG_LEVEL \$KUBE_MASTER \$KUBE_CONTROLLER_MANAGER_ARGS'
128127
ExecStop=-/usr/bin/podman stop kube-controller-manager
129128
Delegate=yes
130129
Restart=always
@@ -153,7 +152,7 @@ ExecStart=/bin/bash -c '/usr/bin/podman run --name kube-scheduler \\
153152
--volume /etc/pki/tls/certs:/usr/share/ca-certificates:ro \\
154153
\${CONTAINER_INFRA_PREFIX:-\${HYPERKUBE_PREFIX}}hyperkube:\${KUBE_TAG} \\
155154
kube-scheduler \\
156-
\$KUBE_LOGTOSTDERR \$KUBE_LOG_LEVEL \$KUBE_MASTER \$KUBE_SCHEDULER_ARGS'
155+
\$KUBE_LOG_LEVEL \$KUBE_MASTER \$KUBE_SCHEDULER_ARGS'
157156
ExecStop=-/usr/bin/podman stop kube-scheduler
158157
Delegate=yes
159158
Restart=always
@@ -208,7 +207,7 @@ ExecStart=/bin/bash -c '/usr/bin/podman run --name kubelet \\
208207
--volume /etc/machine-id:/etc/machine-id \\
209208
\${CONTAINER_INFRA_PREFIX:-\${HYPERKUBE_PREFIX}}hyperkube:\${KUBE_TAG} \\
210209
kubelet \\
211-
\$KUBE_LOGTOSTDERR \$KUBE_LOG_LEVEL \$KUBELET_API_SERVER \$KUBELET_ADDRESS \$KUBELET_PORT \$KUBELET_HOSTNAME \$KUBELET_ARGS'
210+
\$KUBE_LOG_LEVEL \$KUBELET_API_SERVER \$KUBELET_ADDRESS \$KUBELET_PORT \$KUBELET_HOSTNAME \$KUBELET_ARGS'
212211
ExecStop=-/usr/bin/podman stop kubelet
213212
Delegate=yes
214213
Restart=always
@@ -240,7 +239,7 @@ ExecStart=/bin/bash -c '/usr/bin/podman run --name kube-proxy \\
240239
--volume /etc/pki/tls/certs:/usr/share/ca-certificates:ro \\
241240
\${CONTAINER_INFRA_PREFIX:-\${HYPERKUBE_PREFIX}}hyperkube:\${KUBE_TAG} \\
242241
kube-proxy \\
243-
\$KUBE_LOGTOSTDERR \$KUBE_LOG_LEVEL \$KUBE_MASTER \$KUBE_PROXY_ARGS'
242+
\$KUBE_LOG_LEVEL \$KUBE_MASTER \$KUBE_PROXY_ARGS'
244243
ExecStop=-/usr/bin/podman stop kube-proxy
245244
Delegate=yes
246245
Restart=always

magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-minion.sh

+2-3
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ fi
5353

5454
mkdir -p /srv/magnum/kubernetes/
5555
cat > /etc/kubernetes/config <<EOF
56-
KUBE_LOGTOSTDERR="--logtostderr=true"
5756
KUBE_LOG_LEVEL="--v=3"
5857
EOF
5958
cat > /etc/kubernetes/kubelet <<EOF
@@ -106,7 +105,7 @@ ExecStart=/bin/bash -c '/usr/bin/podman run --name kubelet \\
106105
--volume /etc/machine-id:/etc/machine-id \\
107106
\${CONTAINER_INFRA_PREFIX:-\${HYPERKUBE_PREFIX}}hyperkube:\${KUBE_TAG} \\
108107
kubelet \\
109-
\$KUBE_LOGTOSTDERR \$KUBE_LOG_LEVEL \$KUBELET_API_SERVER \$KUBELET_ADDRESS \$KUBELET_PORT \$KUBELET_HOSTNAME \$KUBELET_ARGS'
108+
\$KUBE_LOG_LEVEL \$KUBELET_API_SERVER \$KUBELET_ADDRESS \$KUBELET_PORT \$KUBELET_HOSTNAME \$KUBELET_ARGS'
110109
ExecStop=-/usr/bin/podman stop kubelet
111110
Delegate=yes
112111
Restart=always
@@ -138,7 +137,7 @@ ExecStart=/bin/bash -c '/usr/bin/podman run --name kube-proxy \\
138137
--volume /etc/pki/tls/certs:/usr/share/ca-certificates:ro \\
139138
\${CONTAINER_INFRA_PREFIX:-\${HYPERKUBE_PREFIX}}hyperkube:\${KUBE_TAG} \\
140139
kube-proxy \\
141-
\$KUBE_LOGTOSTDERR \$KUBE_LOG_LEVEL \$KUBE_MASTER \$KUBE_PROXY_ARGS'
140+
\$KUBE_LOG_LEVEL \$KUBE_MASTER \$KUBE_PROXY_ARGS'
142141
ExecStop=-/usr/bin/podman stop kube-proxy
143142
Delegate=yes
144143
Restart=always

0 commit comments

Comments
 (0)