fixes several ansible test failures and flaws

- Fixes bug where reconcile attempted to update status after running finalizer
- Stops depending on grepping for a log statement for a test to pass
- Disables debug log mode by default
- Ensures no errors appear in log at end of e2e test run
- logs cache miss at INFO instead of ERROR
- adds sleep statement to tolerate operator-framework#818 in e2e tests

Author: mhrivnak

hack/tests/e2e-ansible.sh

@@ -72,9 +72,18 @@ then
     exit 1
 fi
 
+# TODO remove when this issue is fixed: https://github.com/operator-framework/operator-sdk/issues/818
+sleep 1
+
+# make a configmap that the finalizer should remove
+kubectl create configmap deleteme
+trap_add 'kubectl delete --ignore-not-found configmap deleteme' EXIT
+
 kubectl delete -f ${DIR2}/deploy/crds/ansible_v1alpha1_memcached_cr.yaml --wait=true
-if ! kubectl logs deployment/memcached-operator | grep "this is a finalizer";
+# if the finalizer did not delete the configmap...
+if kubectl get configmap deleteme;
 then
+    echo FAIL: the finalizer did not delete the configmap
     kubectl logs deployment/memcached-operator
     exit 1
 fi
@@ -86,5 +95,12 @@ then
     exit 1
 fi
 
+if kubectl logs deployment/memcached-operator | grep -i error;
+then
+    echo FAIL: the operator log includes errors
+    kubectl logs deployment/memcached-operator
+    exit 1
+fi
+
 popd
 popd

pkg/ansible/controller/reconcile.go

@@ -186,9 +186,13 @@ func (r *AnsibleOperatorReconciler) Reconcile(request reconcile.Request) (reconc
 		if err != nil {
 			return reconcileResult, err
 		}
+		return reconcileResult, nil
 	}
 	if r.ManageStatus {
 		err = r.markDone(u, statusEvent, failureMessages)
+		if err != nil {
+			logger.Error(err, "failed to mark status done")
+		}
 	}
 	return reconcileResult, err
 }

pkg/ansible/proxy/proxy.go

@@ -93,7 +93,7 @@ func CacheResponseHandler(h http.Handler, informerCache cache.Cache, restMapper
 			if err != nil {
 				// break here in case resource doesn't exist in cache but exists on APIserver
 				// This is very unlikely but provides user with expected 404
-				log.Error(err, "didn't find object in cache")
+				log.Info(fmt.Sprintf("cache miss: %v, %v", k, obj))
 				break
 			}
 

test/ansible-memcached/memfin/tasks/main.yml

@@ -1,2 +1,7 @@
-- debug:
-    msg: "this is a finalizer"
+- name: delete configmap for test
+  k8s:
+    kind: ConfigMap
+    api_version: v1
+    name: deleteme
+    namespace: default
+    state: absent

test/ansible-operator/cmd/ansible-operator/main.go

@@ -39,7 +39,7 @@ func printVersion() {
 func main() {
 	flag.Parse()
 
-	logf.SetLogger(logf.ZapLogger(true))
+	logf.SetLogger(logf.ZapLogger(false))
 
 	namespace, err := k8sutil.GetWatchNamespace()
 	if err != nil {