Revert "Add TableReplicas Support for DynamoDB Table Replicas (aws-controllers-k8s#120)

This reverts commit 755ecd8.
Ensure we keep the field in helm

Author: michaelhtm

Diff for: pkg/resource/table/hooks.go

@@ -15,7 +15,6 @@ package table
 
 import (
 	"context"
-	"errors"
 	"fmt"
 	"strings"
 	"time"
@@ -35,25 +34,21 @@ import (
 
 var (
 	ErrTableDeleting = fmt.Errorf(
-		"table in '%v' state, cannot be modified or deleted",
+		"Table in '%v' state, cannot be modified or deleted",
 		svcsdktypes.TableStatusDeleting,
 	)
 	ErrTableCreating = fmt.Errorf(
-		"table in '%v' state, cannot be modified or deleted",
+		"Table in '%v' state, cannot be modified or deleted",
 		svcsdktypes.TableStatusCreating,
 	)
 	ErrTableUpdating = fmt.Errorf(
-		"table in '%v' state, cannot be modified or deleted",
+		"Table in '%v' state, cannot be modified or deleted",
 		svcsdktypes.TableStatusUpdating,
 	)
 	ErrTableGSIsUpdating = fmt.Errorf(
-		"table GSIs in '%v' state, cannot be modified or deleted",
+		"Table GSIs in '%v' state, cannot be modified or deleted",
 		svcsdktypes.IndexStatusCreating,
 	)
-	ErrTableReplicasUpdating = fmt.Errorf(
-		"table replica in '%v' state, cannot be modified or deleted",
-		svcsdktypes.ReplicaStatusUpdating,
-	)
 )
 
 // TerminalStatuses are the status strings that are terminal states for a
@@ -79,16 +74,12 @@ var (
 	)
 	requeueWaitWhileUpdating = ackrequeue.NeededAfter(
 		ErrTableUpdating,
-		10*time.Second,
+		5*time.Second,
 	)
 	requeueWaitGSIReady = ackrequeue.NeededAfter(
 		ErrTableGSIsUpdating,
 		10*time.Second,
 	)
-	requeueWaitReplicasActive = ackrequeue.NeededAfter(
-		ErrTableReplicasUpdating,
-		10*time.Second,
-	)
 )
 
 // tableHasTerminalStatus returns whether the supplied Dynamodb table is in a
@@ -233,17 +224,6 @@ func (rm *resourceManager) customUpdateTable(
 				}
 				return nil, err
 			}
-		case delta.DifferentAt("Spec.TableReplicas"):
-			// Enabling replicas required streams enabled and StreamViewType to be NEW_AND_OLD_IMAGES
-			// Version 2019.11.21  TableUpdate API requirement
- 			if !hasStreamSpecificationWithNewAndOldImages(desired) {
-				msg := "table must have DynamoDB Streams enabled with StreamViewType set to NEW_AND_OLD_IMAGES for replica updates"
-				rlog.Debug(msg)
-				return nil, ackerr.NewTerminalError(errors.New(msg))
-			}
-			if err := rm.syncReplicas(ctx, latest, desired); err != nil {
-				return nil, err
-			}
 		}
 	}
 
@@ -578,15 +558,6 @@ func customPreCompare(
 		}
 	}
 
-	// Handle ReplicaUpdates API comparison
-	if len(a.ko.Spec.TableReplicas) != len(b.ko.Spec.TableReplicas) {
-		delta.Add("Spec.TableReplicas", a.ko.Spec.TableReplicas, b.ko.Spec.TableReplicas)
-	} else if a.ko.Spec.TableReplicas != nil && b.ko.Spec.TableReplicas != nil {
-		if !equalReplicaArrays(a.ko.Spec.TableReplicas, b.ko.Spec.TableReplicas) {
-			delta.Add("Spec.TableReplicas", a.ko.Spec.TableReplicas, b.ko.Spec.TableReplicas)
-		}
-	}
-
 	if a.ko.Spec.DeletionProtectionEnabled == nil {
 		a.ko.Spec.DeletionProtectionEnabled = aws.Bool(false)
 	}