Skip to content

Commit 6567cdc

Browse files
committed
Merge branch '1.13.x' into 1.14.x
2 parents a1a4f3d + 80d4c9d commit 6567cdc

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

micrometer-jetty12/src/main/java/io/micrometer/jetty12/server/TimedHandler.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,8 @@ private void stopRequestTiming(Request request) {
135135
request.removeAttribute(SAMPLE_REQUEST_LONG_TASK_TIMER_ATTRIBUTE);
136136

137137
requestSample.stop();
138+
139+
shutdown.check();
138140
}
139141

140142
private void beginHandlerTiming(Request request) {

micrometer-jetty12/src/test/java/io/micrometer/jetty12/server/TimedHandlerTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import org.eclipse.jetty.server.*;
2626
import org.eclipse.jetty.util.BufferUtil;
2727
import org.eclipse.jetty.util.Callback;
28-
import org.eclipse.jetty.util.component.Graceful;
2928
import org.eclipse.jetty.util.component.LifeCycle;
3029
import org.junit.jupiter.api.AfterEach;
3130
import org.junit.jupiter.api.BeforeEach;
@@ -166,13 +165,11 @@ public boolean handle(Request request, Response response, Callback callback) {
166165

167166
// initiate a shutdown
168167
Future<Void> shutdownFuture = timedHandler.shutdown();
169-
Graceful.Shutdown shutdown = timedHandler.getShutdown();
170168
assertThat(shutdownFuture.isDone()).isFalse();
171169

172170
// delay half what the handler is sleeping
173171
Thread.sleep(delay / 2);
174172
// response is still active, so don't shutdown.
175-
shutdown.check();
176173
assertThat(shutdownFuture.isDone()).isFalse();
177174

178175
// Read response to ensure it is done
@@ -181,7 +178,6 @@ public boolean handle(Request request, Response response, Callback callback) {
181178
assertThat(response1.getContent()).isEmpty();
182179

183180
Thread.sleep(delay);
184-
shutdown.check();
185181
assertThat(shutdownFuture.isDone()).isTrue();
186182
}
187183
}

0 commit comments

Comments
 (0)