Skip to content

Commit 689bbcd

Browse files
authored
Declare ContainerRuntime class as implementing interfaces it already implements (#24147)
We've hidden the fact that ContainerRuntime class implements certain interfaces to reduce exposure while ContainerRuntime was not internal. Now that it is, we can declare that it implements these interfaces. It makes the code clearer, and code navigation works better.
1 parent 048a1d5 commit 689bbcd

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed

packages/runtime/container-runtime/src/containerRuntime.ts

+4
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ import type {
9090
IInboundSignalMessage,
9191
IRuntimeMessagesContent,
9292
ISummarizerNodeWithGC,
93+
IFluidParentContext,
9394
} from "@fluidframework/runtime-definitions/internal";
9495
import {
9596
FlushMode,
@@ -168,6 +169,7 @@ import {
168169
IGarbageCollector,
169170
gcGenerationOptionName,
170171
type GarbageCollectionMessage,
172+
type IGarbageCollectionRuntime,
171173
} from "./gc/index.js";
172174
import { InboundBatchAggregator } from "./inboundBatchAggregator.js";
173175
import {
@@ -719,8 +721,10 @@ export class ContainerRuntime
719721
implements
720722
IContainerRuntime,
721723
IRuntime,
724+
IGarbageCollectionRuntime,
722725
ISummarizerRuntime,
723726
ISummarizerInternalsProvider,
727+
IFluidParentContext,
724728
IProvideFluidHandleContext,
725729
IProvideLayerCompatDetails
726730
{

packages/runtime/container-runtime/src/gc/gcDefinitions.ts

+2
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,8 @@ export type GarbageCollectionMessage = ISweepMessage | ITombstoneLoadedMessage;
333333

334334
/**
335335
* Defines the APIs for the runtime object to be passed to the garbage collector.
336+
*
337+
* @internal
336338
*/
337339
export interface IGarbageCollectionRuntime {
338340
/**

packages/runtime/container-runtime/src/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ export {
3535
IGCMetadata,
3636
GCFeatureMatrix,
3737
GCVersion,
38+
IGarbageCollectionRuntime,
3839
IGCRuntimeOptions,
3940
IMarkPhaseStats,
4041
ISweepPhaseStats,

0 commit comments

Comments
 (0)