datastore manager build errors

Author: tylerbutler

packages/framework/presence/src/latestMapValueManager.ts

@@ -521,7 +521,7 @@ class LatestMapValueManagerImpl<
 					key,
 					value: itemValue,
 					metadata,
-				} satisfies LatestMapItemUpdatedClientData<T, Keys>;
+				} satisfies LatestMapItemUpdatedClientData<T, Keys, RawValueAccessor<T>>;
 				postUpdateActions.push(() => this.events.emit("remoteItemUpdated", updatedItem));
 				allUpdates.items.set(key, { value: itemValue, metadata });
 			} else if (hadPriorValue !== undefined) {

packages/framework/presence/src/latestValueManager.ts

@@ -154,19 +154,20 @@ class LatestValueManagerImpl<T, Key extends string>
 		this.events.emit("localUpdated", { value: asDeeplyReadonly(value) });
 	}
 
-	public getRemotes: () => IterableIterator<LatestClientData<T, ValueAccessor<T>>> =
-		function* (this: LatestValueManagerImpl<T, Key>) {
-			const allKnownStates = this.datastore.knownValues(this.key);
-			for (const [attendeeId, value] of objectEntries(allKnownStates.states)) {
-				if (attendeeId !== allKnownStates.self) {
-					yield {
-						attendee: this.datastore.lookupClient(attendeeId),
-						value: asDeeplyReadonly(value.value),
-						metadata: { revision: value.rev, timestamp: value.timestamp },
-					};
-				}
+	public *getRemotes(
+		this: LatestValueManagerImpl<T, Key>,
+	): IterableIterator<LatestClientData<T, ValueAccessor<T>>> {
+		const allKnownStates = this.datastore.knownValues(this.key);
+		for (const [attendeeId, value] of objectEntries(allKnownStates.states)) {
+			if (attendeeId !== allKnownStates.self) {
+				yield {
+					attendee: this.datastore.lookupClient(attendeeId),
+					value: asDeeplyReadonly(unbrandJson(value.value)),
+					metadata: { revision: value.rev, timestamp: value.timestamp },
+				};
 			}
-		};
+		}
+	}
 
 	public getStateAttendees(): Attendee[] {
 		const allKnownStates = this.datastore.knownValues(this.key);
@@ -268,8 +269,7 @@ export function latest<T extends object | null, Key extends string = string>(
 	const internalValue =
 		local === null
 			? (local as unknown as InternalUtilityTypes.OpaqueJsonDeserialized<T>)
-			: // FIXME: Why isn't this directly castable?
-				(shallowCloneObject(
+			: (shallowCloneObject(
 					local,
 				) as unknown as InternalUtilityTypes.OpaqueJsonDeserialized<T>);
 	const value: InternalTypes.ValueRequiredState<T> = {

packages/framework/presence/src/latestValueTypes.ts

@@ -93,14 +93,6 @@ export interface LatestData<T, TValueAccessor extends ValueAccessor<T>> {
 		: TValueAccessor extends RawValueAccessor<T>
 			? DeepReadonly<JsonDeserialized<T>>
 			: never;
-	// value: TValueAccessor;
-	// value: [T] extends [ProxiedValueAccessor<T>]
-	// 	? () => DeepReadonly<JsonDeserialized<T>> | undefined
-	// 	: [T] extends [RawValueAccessor<T>]
-	// 		? DeepReadonly<JsonDeserialized<T>>
-	// 		: never;
-	// value: Accessor<TValueAccessor>;
-	// value: TValueAccessor;
 	metadata: LatestMetadata;
 }