Skip to content

// @ts-check complains about screen.orientation and suggest msOrientation #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjbvz opened this issue Sep 14, 2017 · 3 comments
Closed

Comments

@mjbvz
Copy link

mjbvz commented Sep 14, 2017

From @kenchris on September 14, 2017 13:42

[js] Property 'orientation' does not exist on type 'Screen'. Did you mean 'msOrientation'?

Though screen.orientation is what Chrome uses

mat4.rotateZ(this.rotationMatrix, this.rotationMatrix, toRad(window.screen.orientation.angle || 0));

Copied from original issue: microsoft/vscode#34381

@mhegazy
Copy link
Contributor

mhegazy commented Sep 14, 2017

@mhegazy
Copy link
Contributor

mhegazy commented Sep 14, 2017

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

@mhegazy
Copy link
Contributor

mhegazy commented Sep 14, 2017

closing in favor of microsoft/TypeScript#18480

@mhegazy mhegazy closed this as completed Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants