From 7794e5f9c42aeb12e280533537044cb14efde14e Mon Sep 17 00:00:00 2001 From: Risu <79110363+risu729@users.noreply.github.com> Date: Mon, 3 Mar 2025 01:24:55 +0900 Subject: [PATCH 1/3] Update moduleResolution defaults in tsconfigRules --- packages/tsconfig-reference/scripts/tsconfigRules.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/tsconfig-reference/scripts/tsconfigRules.ts b/packages/tsconfig-reference/scripts/tsconfigRules.ts index 90c39046a90f..5081615f2da9 100644 --- a/packages/tsconfig-reference/scripts/tsconfigRules.ts +++ b/packages/tsconfig-reference/scripts/tsconfigRules.ts @@ -238,9 +238,11 @@ export const defaultsForOptions = { "`ES6`/`ES2015` otherwise.", ], moduleResolution: [ - "`Classic` if [`module`](#module) is `AMD`, `UMD`, `System`, or `ES6`/`ES2015`;", - "Matches if [`module`](#module) is `node16` or `nodenext`;", - "`Node` otherwise.", + "`Node10` if [`module`](#module) is `CommonJS`;", + "`Node16` if [`module`](#module) is `Node16` or `Node18`;", + "`NodeNext` if [`module`](#module) is `NodeNext`;", + "`Preserve` if [`module`](#module) is `Bundler`;", + "`Classic` otherwise.", ], newLine: "`lf`", noImplicitAny: trueIf("strict"), From 0bb3b786b7b76b65cbe87a68628a7bdd7fb01dfa Mon Sep 17 00:00:00 2001 From: Risu <79110363+risu729@users.noreply.github.com> Date: Mon, 3 Mar 2025 07:34:49 +1100 Subject: [PATCH 2/3] Update generated code --- .../documentation/copy/en/project-config/Compiler Options.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/documentation/copy/en/project-config/Compiler Options.md b/packages/documentation/copy/en/project-config/Compiler Options.md index 395d43d3f2be..5a3c427c5edc 100644 --- a/packages/documentation/copy/en/project-config/Compiler Options.md +++ b/packages/documentation/copy/en/project-config/Compiler Options.md @@ -868,7 +868,7 @@ tsc app.ts util.ts --target esnext --outfile index.js --moduleResolution

classic, node10/node, node16, nodenext, or bundler

-

Classic if module is AMD, UMD, System, or ES6/ES2015; Matches if module is node16 or nodenext; Node otherwise.

+

Node10 if module is CommonJS; Node16 if module is Node16 or Node18; NodeNext if module is NodeNext; Preserve if module is Bundler; Classic otherwise.

From 446aa75d9d466e69336a669d70a7e3f551602b48 Mon Sep 17 00:00:00 2001 From: Andrew Branch Date: Wed, 5 Mar 2025 07:45:25 -0800 Subject: [PATCH 3/3] Apply suggestions from code review Swap bundler/preserve --- .../documentation/copy/en/project-config/Compiler Options.md | 2 +- packages/tsconfig-reference/scripts/tsconfigRules.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/documentation/copy/en/project-config/Compiler Options.md b/packages/documentation/copy/en/project-config/Compiler Options.md index 5a3c427c5edc..99f06d830936 100644 --- a/packages/documentation/copy/en/project-config/Compiler Options.md +++ b/packages/documentation/copy/en/project-config/Compiler Options.md @@ -868,7 +868,7 @@ tsc app.ts util.ts --target esnext --outfile index.js --moduleResolution

classic, node10/node, node16, nodenext, or bundler

-

Node10 if module is CommonJS; Node16 if module is Node16 or Node18; NodeNext if module is NodeNext; Preserve if module is Bundler; Classic otherwise.

+

Node10 if module is CommonJS; Node16 if module is Node16 or Node18; NodeNext if module is NodeNext; Bundler if module is Preserve; Classic otherwise.

diff --git a/packages/tsconfig-reference/scripts/tsconfigRules.ts b/packages/tsconfig-reference/scripts/tsconfigRules.ts index 5081615f2da9..53f9de250041 100644 --- a/packages/tsconfig-reference/scripts/tsconfigRules.ts +++ b/packages/tsconfig-reference/scripts/tsconfigRules.ts @@ -241,7 +241,7 @@ export const defaultsForOptions = { "`Node10` if [`module`](#module) is `CommonJS`;", "`Node16` if [`module`](#module) is `Node16` or `Node18`;", "`NodeNext` if [`module`](#module) is `NodeNext`;", - "`Preserve` if [`module`](#module) is `Bundler`;", + "`Bundler` if [`module`](#module) is `Preserve`;", "`Classic` otherwise.", ], newLine: "`lf`",