fix: also add record in es5.d.ts

Author: christophehurpeau

lib/lib.es5.d.ts

@@ -258,7 +258,7 @@ interface ObjectConstructor {
       * Returns the names of the enumerable properties and methods of an object.
       * @param o Object that contains the properties and methods. This can be an object that you created or an existing Document Object Model (DOM) object.
       */
-    keys<K extends string>(record: Record<K, any>): K[];
+    keys<K extends string>(o: Record<K, any>): K[];
     keys(o: {}): string[];
 }
 

src/lib/es5.d.ts

@@ -238,6 +238,7 @@ interface ObjectConstructor {
       * Returns the names of the enumerable properties and methods of an object.
       * @param o Object that contains the properties and methods. This can be an object that you created or an existing Document Object Model (DOM) object.
       */
+    keys<K extends string>(o: Record<K, any>): K[];
     keys(o: {}): string[];
 }
 
@@ -577,7 +578,7 @@ interface TemplateStringsArray extends ReadonlyArray<string> {
 
 /**
  * The type of `import.meta`.
- * 
+ *
  * If you need to declare that a given property exists on `import.meta`,
  * this type may be augmented via interface merging.
  */

tests/baselines/reference/conditionalTypeDoesntSpinForever.symbols

@@ -403,9 +403,9 @@ export enum PubSubRecordIsStoredInRedisAsA {
       fields: () => new Set(Object.keys(soFar) as (keyof SO_FAR)[]),
 >fields : Symbol(fields, Decl(conditionalTypeDoesntSpinForever.ts, 94, 18))
 >Set : Symbol(Set, Decl(lib.es2015.collection.d.ts, --, --), Decl(lib.es2015.collection.d.ts, --, --), Decl(lib.es2015.iterable.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
->Object.keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --))
+>Object.keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
 >Object : Symbol(Object, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
->keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --))
+>keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
 >soFar : Symbol(soFar, Decl(conditionalTypeDoesntSpinForever.ts, 92, 29))
 >SO_FAR : Symbol(SO_FAR, Decl(conditionalTypeDoesntSpinForever.ts, 92, 21))
 

tests/baselines/reference/conditionalTypeDoesntSpinForever.types

@@ -409,10 +409,10 @@ export enum PubSubRecordIsStoredInRedisAsA {
 >new Set(Object.keys(soFar) as (keyof SO_FAR)[]) : Set<keyof SO_FAR>
 >Set : SetConstructor
 >Object.keys(soFar) as (keyof SO_FAR)[] : (keyof SO_FAR)[]
->Object.keys(soFar) : string[]
->Object.keys : (o: {}) => string[]
+>Object.keys(soFar) : never[]
+>Object.keys : { <K extends string>(o: Record<K, any>): K[]; (o: {}): string[]; }
 >Object : ObjectConstructor
->keys : (o: {}) => string[]
+>keys : { <K extends string>(o: Record<K, any>): K[]; (o: {}): string[]; }
 >soFar : SO_FAR
 
       hasField: (fieldName: string | number | symbol) => fieldName in soFar

tests/baselines/reference/contextualExpressionTypecheckingDoesntBlowStack.symbols

@@ -21,9 +21,9 @@ export default class Operation {
 
         for(const parameterLocation of Object.keys(parameterValues)) {
 >parameterLocation : Symbol(parameterLocation, Decl(contextualExpressionTypecheckingDoesntBlowStack.ts, 8, 17))
->Object.keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --))
+>Object.keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
 >Object : Symbol(Object, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
->keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --))
+>keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
 >parameterValues : Symbol(parameterValues, Decl(contextualExpressionTypecheckingDoesntBlowStack.ts, 6, 23))
 
             const parameter: any = (this as any).getParameter();;

tests/baselines/reference/contextualExpressionTypecheckingDoesntBlowStack.types

@@ -21,9 +21,9 @@ export default class Operation {
         for(const parameterLocation of Object.keys(parameterValues)) {
 >parameterLocation : string
 >Object.keys(parameterValues) : string[]
->Object.keys : (o: {}) => string[]
+>Object.keys : { <K extends string>(o: Record<K, any>): K[]; (o: {}): string[]; }
 >Object : ObjectConstructor
->keys : (o: {}) => string[]
+>keys : { <K extends string>(o: Record<K, any>): K[]; (o: {}): string[]; }
 >parameterValues : any
 
             const parameter: any = (this as any).getParameter();;

tests/baselines/reference/externModule.errors.txt

@@ -69,20 +69,20 @@ tests/cases/compiler/externModule.ts(37,3): error TS2552: Cannot find name 'XDat
     var d=new XDate();
               ~~~~~
 !!! error TS2552: Cannot find name 'XDate'. Did you mean 'Date'?
-!!! related TS2728 /.ts/lib.es5.d.ts:897:15: 'Date' is declared here.
+!!! related TS2728 /.ts/lib.es5.d.ts:898:15: 'Date' is declared here.
     d.getDay();
     d=new XDate(1978,2);
           ~~~~~
 !!! error TS2552: Cannot find name 'XDate'. Did you mean 'Date'?
-!!! related TS2728 /.ts/lib.es5.d.ts:897:15: 'Date' is declared here.
+!!! related TS2728 /.ts/lib.es5.d.ts:898:15: 'Date' is declared here.
     d.getXDate();
     var n=XDate.parse("3/2/2004");
           ~~~~~
 !!! error TS2552: Cannot find name 'XDate'. Did you mean 'Date'?
-!!! related TS2728 /.ts/lib.es5.d.ts:897:15: 'Date' is declared here.
+!!! related TS2728 /.ts/lib.es5.d.ts:898:15: 'Date' is declared here.
     n=XDate.UTC(1964,2,1);
       ~~~~~
 !!! error TS2552: Cannot find name 'XDate'. Did you mean 'Date'?
-!!! related TS2728 /.ts/lib.es5.d.ts:897:15: 'Date' is declared here.
+!!! related TS2728 /.ts/lib.es5.d.ts:898:15: 'Date' is declared here.
 
 

tests/baselines/reference/genericIndexedAccessMethodIntersectionCanBeAccessed.symbols

@@ -45,9 +45,9 @@ export const createService = <T>(
 ) => {
     Object.keys(ServiceCtr).forEach(key => {
 >Object.keys(ServiceCtr).forEach : Symbol(Array.forEach, Decl(lib.es5.d.ts, --, --))
->Object.keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --))
+>Object.keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
 >Object : Symbol(Object, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
->keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --))
+>keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
 >ServiceCtr : Symbol(ServiceCtr, Decl(genericIndexedAccessMethodIntersectionCanBeAccessed.ts, 11, 33))
 >forEach : Symbol(Array.forEach, Decl(lib.es5.d.ts, --, --))
 >key : Symbol(key, Decl(genericIndexedAccessMethodIntersectionCanBeAccessed.ts, 14, 36))

tests/baselines/reference/genericIndexedAccessMethodIntersectionCanBeAccessed.types

@@ -32,9 +32,9 @@ export const createService = <T>(
 >Object.keys(ServiceCtr).forEach(key => {        const method = (ServiceCtr)[key as keyof T];        const {__$daemonMode, __$action, id} = method;    }) : void
 >Object.keys(ServiceCtr).forEach : (callbackfn: (value: string, index: number, array: string[]) => void, thisArg?: any) => void
 >Object.keys(ServiceCtr) : string[]
->Object.keys : (o: {}) => string[]
+>Object.keys : { <K extends string>(o: Record<K, any>): K[]; (o: {}): string[]; }
 >Object : ObjectConstructor
->keys : (o: {}) => string[]
+>keys : { <K extends string>(o: Record<K, any>): K[]; (o: {}): string[]; }
 >ServiceCtr : ExtendedService<T> & Service<T>
 >forEach : (callbackfn: (value: string, index: number, array: string[]) => void, thisArg?: any) => void
 >key => {        const method = (ServiceCtr)[key as keyof T];        const {__$daemonMode, __$action, id} = method;    } : (key: string) => void

tests/baselines/reference/modularizeLibrary_ErrorFromUsingES6FeaturesWithOnlyES5Lib.errors.txt

@@ -41,7 +41,7 @@ tests/cases/compiler/modularizeLibrary_ErrorFromUsingES6FeaturesWithOnlyES5Lib.t
     Math.sign(1);
          ~~~~
 !!! error TS2551: Property 'sign' does not exist on type 'Math'. Did you mean 'sin'?
-!!! related TS2728 /.ts/lib.es5.d.ts:703:5: 'sin' is declared here.
+!!! related TS2728 /.ts/lib.es5.d.ts:704:5: 'sin' is declared here.
 
     // Using ES6 object
     var o = {

tests/baselines/reference/objectKeysWithRecord.symbols

@@ -11,9 +11,9 @@ const record: Record<K, boolean> = { foo: true, bar: false };
 
 Object.keys(record).forEach((key: K) => {
 >Object.keys(record).forEach : Symbol(Array.forEach, Decl(lib.es5.d.ts, --, --))
->Object.keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --))
+>Object.keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
 >Object : Symbol(Object, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
->keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --))
+>keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
 >record : Symbol(record, Decl(objectKeysWithRecord.ts, 1, 5))
 >forEach : Symbol(Array.forEach, Decl(lib.es5.d.ts, --, --))
 >key : Symbol(key, Decl(objectKeysWithRecord.ts, 3, 29))

tests/baselines/reference/objectKeysWithRecord.types

@@ -12,13 +12,13 @@ const record: Record<K, boolean> = { foo: true, bar: false };
 
 Object.keys(record).forEach((key: K) => {
 >Object.keys(record).forEach((key: K) => {}) : void
->Object.keys(record).forEach : (callbackfn: (value: string, index: number, array: string[]) => void, thisArg?: any) => void
->Object.keys(record) : string[]
->Object.keys : (o: {}) => string[]
+>Object.keys(record).forEach : (callbackfn: (value: K, index: number, array: K[]) => void, thisArg?: any) => void
+>Object.keys(record) : K[]
+>Object.keys : { <K extends string>(o: Record<K, any>): K[]; (o: {}): string[]; }
 >Object : ObjectConstructor
->keys : (o: {}) => string[]
+>keys : { <K extends string>(o: Record<K, any>): K[]; (o: {}): string[]; }
 >record : Record<K, boolean>
->forEach : (callbackfn: (value: string, index: number, array: string[]) => void, thisArg?: any) => void
+>forEach : (callbackfn: (value: K, index: number, array: K[]) => void, thisArg?: any) => void
 >(key: K) => {} : (key: K) => void
 >key : K
 

tests/baselines/reference/promisePermutations.errors.txt

@@ -295,7 +295,7 @@ tests/cases/compiler/promisePermutations.ts(160,21): error TS2345: Argument of t
                                        ~~~~~~~~~
 !!! error TS2345: Argument of type '(x: any) => IPromise<string>' is not assignable to parameter of type '(error: any) => Promise<number>'.
 !!! error TS2345:   Property 'catch' is missing in type 'IPromise<string>' but required in type 'Promise<number>'.
-!!! related TS2728 /.ts/lib.es5.d.ts:1403:5: 'catch' is declared here.
+!!! related TS2728 /.ts/lib.es5.d.ts:1404:5: 'catch' is declared here.
     var s10g = s10.then(testFunctionP, nIPromise, sIPromise).then(sPromise, sIPromise, sIPromise); // ok
 
     var r11: IPromise<number>;

tests/baselines/reference/promisePermutations2.errors.txt

@@ -294,7 +294,7 @@ tests/cases/compiler/promisePermutations2.ts(159,21): error TS2345: Argument of
                                        ~~~~~~~~~
 !!! error TS2345: Argument of type '(x: any) => IPromise<string>' is not assignable to parameter of type '(error: any) => Promise<number>'.
 !!! error TS2345:   Property 'catch' is missing in type 'IPromise<string>' but required in type 'Promise<number>'.
-!!! related TS2728 /.ts/lib.es5.d.ts:1403:5: 'catch' is declared here.
+!!! related TS2728 /.ts/lib.es5.d.ts:1404:5: 'catch' is declared here.
     var s10g = s10.then(testFunctionP, nIPromise, sIPromise).then(sPromise, sIPromise, sIPromise); // ok
 
     var r11: IPromise<number>;

tests/baselines/reference/promisePermutations3.errors.txt

@@ -303,7 +303,7 @@ tests/cases/compiler/promisePermutations3.ts(165,21): error TS2345: Argument of
                                        ~~~~~~~~~
 !!! error TS2345: Argument of type '(x: any) => IPromise<string>' is not assignable to parameter of type '(error: any) => Promise<number>'.
 !!! error TS2345:   Property 'catch' is missing in type 'IPromise<string>' but required in type 'Promise<number>'.
-!!! related TS2728 /.ts/lib.es5.d.ts:1403:5: 'catch' is declared here.
+!!! related TS2728 /.ts/lib.es5.d.ts:1404:5: 'catch' is declared here.
     var s10g = s10.then(testFunctionP, nIPromise, sIPromise).then(sPromise, sIPromise, sIPromise); // ok
 
     var r11: IPromise<number>;
@@ -340,5 +340,5 @@ tests/cases/compiler/promisePermutations3.ts(165,21): error TS2345: Argument of
                         ~~~~~~~~~~~~~~~
 !!! error TS2345: Argument of type '{ <T>(x: T): IPromise<T>; <T>(x: T, y: T): Promise<T>; }' is not assignable to parameter of type '(value: (x: any) => any) => Promise<{}>'.
 !!! error TS2345:   Property 'catch' is missing in type 'IPromise<any>' but required in type 'Promise<{}>'.
-!!! related TS2728 /.ts/lib.es5.d.ts:1403:5: 'catch' is declared here.
+!!! related TS2728 /.ts/lib.es5.d.ts:1404:5: 'catch' is declared here.
     var s12c = s12.then(testFunction12P, testFunction12, testFunction12); // ok

tests/baselines/reference/promiseTypeInference.errors.txt

@@ -26,5 +26,5 @@ tests/cases/compiler/promiseTypeInference.ts(10,39): error TS2322: Type 'IPromis
 !!! error TS2322:         Types of parameters 'success' and 'onfulfilled' are incompatible.
 !!! error TS2322:           Type 'TResult1 | PromiseLike<TResult1>' is not assignable to type 'IPromise<TResult1 | TResult2>'.
 !!! error TS2322:             Type 'TResult1' is not assignable to type 'IPromise<TResult1 | TResult2>'.
-!!! related TS6502 /.ts/lib.es5.d.ts:1396:57: The expected type comes from the return type of this signature.
+!!! related TS6502 /.ts/lib.es5.d.ts:1397:57: The expected type comes from the return type of this signature.
 

tests/baselines/reference/recursiveTypeRelations.symbols

@@ -90,9 +90,9 @@ export function css<S extends { [K in keyof S]: string }>(styles: S, ...classNam
 
       return Object.keys(arg).reduce<ClassNameObject>((obj: ClassNameObject, key: keyof S) => {
 >Object.keys(arg).reduce : Symbol(Array.reduce, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
->Object.keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --))
+>Object.keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
 >Object : Symbol(Object, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
->keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --))
+>keys : Symbol(ObjectConstructor.keys, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
 >arg : Symbol(arg, Decl(recursiveTypeRelations.ts, 18, 30))
 >reduce : Symbol(Array.reduce, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
 >obj : Symbol(obj, Decl(recursiveTypeRelations.ts, 26, 55))

tests/baselines/reference/recursiveTypeRelations.types

@@ -72,9 +72,9 @@ export function css<S extends { [K in keyof S]: string }>(styles: S, ...classNam
 >Object.keys(arg).reduce<ClassNameObject>((obj: ClassNameObject, key: keyof S) => {        const exportedClassName = styles[key];        obj[exportedClassName] = (arg as ClassNameMap<S>)[key];         return obj;      }, {}) : any
 >Object.keys(arg).reduce : { (callbackfn: (previousValue: string, currentValue: string, currentIndex: number, array: string[]) => string): string; (callbackfn: (previousValue: string, currentValue: string, currentIndex: number, array: string[]) => string, initialValue: string): string; <U>(callbackfn: (previousValue: U, currentValue: string, currentIndex: number, array: string[]) => U, initialValue: U): U; }
 >Object.keys(arg) : string[]
->Object.keys : (o: {}) => string[]
+>Object.keys : { <K extends string>(o: Record<K, any>): K[]; (o: {}): string[]; }
 >Object : ObjectConstructor
->keys : (o: {}) => string[]
+>keys : { <K extends string>(o: Record<K, any>): K[]; (o: {}): string[]; }
 >arg : ClassNameObjectMap<S>
 >reduce : { (callbackfn: (previousValue: string, currentValue: string, currentIndex: number, array: string[]) => string): string; (callbackfn: (previousValue: string, currentValue: string, currentIndex: number, array: string[]) => string, initialValue: string): string; <U>(callbackfn: (previousValue: U, currentValue: string, currentIndex: number, array: string[]) => U, initialValue: U): U; }
 >(obj: ClassNameObject, key: keyof S) => {        const exportedClassName = styles[key];        obj[exportedClassName] = (arg as ClassNameMap<S>)[key];         return obj;      } : (obj: any, key: keyof S) => any

tests/cases/compiler/objectKeysWithRecord.ts

@@ -1,3 +1,4 @@
+// @strictFunctionTypes: true
 type K = 'foo' | 'bar'
 const record: Record<K, boolean> = { foo: true, bar: false };