Fix tests

Author: amcasey

Diff for: src/compiler/checker.ts

@@ -316,7 +316,8 @@ namespace ts {
         let instantiationDepth = 0;
         let constraintDepth = 0;
         let currentNode: Node | undefined;
-        let typeCatalog: Type[] = []; // NB: id is index + 1
+
+        const typeCatalog: Type[] = []; // NB: id is index + 1
 
         const emptySymbols = createSymbolTable();
         const arrayVariances = [VarianceFlags.Covariant];

Diff for: src/compiler/sys.ts

@@ -1209,6 +1209,7 @@ namespace ts {
                         _fs.closeSync(fd);
                     }
                     catch {
+                        // ignore
                     }
                 },
                 readFile,

Diff for: src/compiler/tracing.ts

@@ -1,12 +1,12 @@
 /*@internal*/
 /** Tracing events for the compiler. */
 namespace ts.tracing {
-    type writeFn = (data: string) => void;
+    type WriteFn = (data: string) => void;
 
-    let write: writeFn | undefined = undefined;
+    let write: WriteFn | undefined;
 
     /** Enables (and resets) tracing events for the compiler. */
-    export function startTracing(w: writeFn) {
+    export function startTracing(w: WriteFn) {
         write = w;
         write(`[\n`);
     }
@@ -53,7 +53,7 @@ namespace ts.tracing {
         };
     }
 
-    export function dumpTypes(types: readonly Type[], write: writeFn) {
+    export function dumpTypes(types: readonly Type[], write: WriteFn) {
         performance.mark("beginDumpTypes");
 
         const numTypes = types.length;
@@ -68,7 +68,7 @@ namespace ts.tracing {
             const firstFile = firstDeclaration && getSourceFileOfNode(firstDeclaration);
 
             // It's slow to compute the display text, so skip it unless it's really valuable (or cheap)
-            let display = undefined;
+            let display: string | undefined;
             if ((objectFlags & ObjectFlags.Anonymous) | (type.flags & TypeFlags.Literal)) {
                 try {
                     display = type.checker?.typeToString(type);
@@ -123,9 +123,9 @@ namespace ts.tracing {
                     start: indexFromOne(getLineAndCharacterOfPosition(firstFile, firstDeclaration.pos)),
                     end: indexFromOne(getLineAndCharacterOfPosition(getSourceFileOfNode(firstDeclaration), firstDeclaration.end)),
                 },
-                flags: ts.Debug.formatTypeFlags(type.flags).split("|"),
+                flags: Debug.formatTypeFlags(type.flags).split("|"),
                 display,
-            }
+            };
 
             write(JSON.stringify(descriptor));
             if (i < numTypes - 1) {

Diff for: src/harness/fakesHosts.ts

@@ -37,7 +37,8 @@ namespace fakes {
             return true;
         }
 
-        public write(message: string) {
+        public write(message: string, fd?: number) {
+            assert.isUndefined(fd);
             this.output.push(message);
         }
 
@@ -60,6 +61,15 @@ namespace fakes {
             this.vfs.unlinkSync(path);
         }
 
+        public openFile(_path: string, _mode: "w"): number | undefined {
+            assert.fail("NYI");
+            return undefined;
+        }
+
+        public closeFile(_fd: number): void{
+            assert.fail("NYI");
+        }
+
         public fileExists(path: string) {
             const stats = this._getStats(path);
             return stats ? stats.isFile() : false;

Diff for: src/harness/harnessLanguageService.ts

@@ -724,7 +724,8 @@ namespace Harness.LanguageService {
 
         onMessage = ts.noop;
         writeMessage = ts.noop; // overridden
-        write(message: string): void {
+        write(message: string, fd?: number): void {
+            assert.isUndefined(fd);
             this.writeMessage(message);
         }
 
@@ -744,6 +745,9 @@ namespace Harness.LanguageService {
 
         writeFile = ts.noop;
 
+        openFile = ts.returnUndefined;
+        closeFile = ts.noop;
+
         resolvePath(path: string): string {
             return path;
         }

Diff for: src/harness/virtualFileSystemWithWatch.ts

@@ -1011,11 +1011,21 @@ interface Array<T> { length: number; [n: number]: T; }`
             }
         }
 
+        openFile(_path: string, _mode: "w"): number | undefined {
+            assert.fail("NYI");
+            return undefined;
+        }
+
+        closeFile(_fd: number): void {
+            assert.fail("NYI");
+        }
+
         appendFile(path: string, content: string, options?: Partial<ReloadWatchInvokeOptions>): void {
             this.modifyFile(path, this.readFile(path) + content, options);
         }
 
-        write(message: string) {
+        write(message: string, fd?: number) {
+            assert.isUndefined(fd);
             this.output.push(message);
         }
 

Diff for: src/testRunner/unittests/tsserver/session.ts

@@ -7,9 +7,11 @@ namespace ts.server {
         args: [],
         newLine: "\n",
         useCaseSensitiveFileNames: true,
-        write(s): void { lastWrittenToHost = s; },
+        write(s, _fd: number): void { lastWrittenToHost = s; },
         readFile: returnUndefined,
         writeFile: noop,
+        openFile: returnUndefined,
+        closeFile: noop,
         resolvePath(): string { return undefined!; }, // TODO: GH#18217
         fileExists: () => false,
         directoryExists: () => false,

Diff for: tests/baselines/reference/api/tsserverlibrary.d.ts

@@ -2053,6 +2053,7 @@ declare namespace ts {
          * Gets a type checker that can be used to semantically analyze source files in the program.
          */
         getTypeChecker(): TypeChecker;
+        getTypeCatalog(): readonly Type[];
         getNodeCount(): number;
         getIdentifierCount(): number;
         getSymbolCount(): number;
@@ -3842,11 +3843,13 @@ declare namespace ts {
         args: string[];
         newLine: string;
         useCaseSensitiveFileNames: boolean;
-        write(s: string): void;
+        write(s: string, fd?: number): void;
         writeOutputIsTTY?(): boolean;
         readFile(path: string, encoding?: string): string | undefined;
         getFileSize?(path: string): number;
         writeFile(path: string, data: string, writeByteOrderMark?: boolean): void;
+        openFile(path: string, mode: "w"): number | undefined;
+        closeFile(fd: number): void;
         /**
          * @pollingInterval - this parameter is used in polling-based watchers and ignored in watchers that
          * use native OS file watching

Diff for: tests/baselines/reference/api/typescript.d.ts

@@ -2053,6 +2053,7 @@ declare namespace ts {
          * Gets a type checker that can be used to semantically analyze source files in the program.
          */
         getTypeChecker(): TypeChecker;
+        getTypeCatalog(): readonly Type[];
         getNodeCount(): number;
         getIdentifierCount(): number;
         getSymbolCount(): number;
@@ -3842,11 +3843,13 @@ declare namespace ts {
         args: string[];
         newLine: string;
         useCaseSensitiveFileNames: boolean;
-        write(s: string): void;
+        write(s: string, fd?: number): void;
         writeOutputIsTTY?(): boolean;
         readFile(path: string, encoding?: string): string | undefined;
         getFileSize?(path: string): number;
         writeFile(path: string, data: string, writeByteOrderMark?: boolean): void;
+        openFile(path: string, mode: "w"): number | undefined;
+        closeFile(fd: number): void;
         /**
          * @pollingInterval - this parameter is used in polling-based watchers and ignored in watchers that
          * use native OS file watching

Diff for: tests/baselines/reference/showConfig/Shows tsconfig for single option/generateTrace/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "generateTrace": "./someString"
+    }
+}