Skip to content

Commit 680a716

Browse files
author
Yui
committed
Merge pull request #1894 from Microsoft/updateRwcAndTest262Runner
Update rwc and test262 runner
2 parents 35dde28 + 78efa97 commit 680a716

File tree

4 files changed

+41
-20
lines changed

4 files changed

+41
-20
lines changed

Diff for: Jakefile

+11-7
Original file line numberDiff line numberDiff line change
@@ -457,14 +457,16 @@ directory(builtLocalDirectory);
457457
var run = path.join(builtLocalDirectory, "run.js");
458458
compileFile(run, harnessSources, [builtLocalDirectory, tscFile].concat(libraryTargets).concat(harnessSources), [], /*useBuiltCompiler:*/ true);
459459

460+
var internalTests = "internal/"
461+
460462
var localBaseline = "tests/baselines/local/";
461463
var refBaseline = "tests/baselines/reference/";
462464

463-
var localRwcBaseline = "tests/baselines/rwc/local/";
464-
var refRwcBaseline = "tests/baselines/rwc/reference/";
465+
var localRwcBaseline = path.join(internalTests, "baselines/rwc/local");
466+
var refRwcBaseline = path.join(internalTests, "baselines/rwc/reference");
465467

466-
var localTest262Baseline = "tests/baselines/test262/local/";
467-
var refTest262Baseline = "tests/baselines/test262/reference/";
468+
var localTest262Baseline = path.join(internalTests, "baselines/test262/local");
469+
var refTest262Baseline = path.join(internalTests, "baselines/test262/reference");
468470

469471
desc("Builds the test infrastructure using the built compiler");
470472
task("tests", ["local", run].concat(libraryTargets));
@@ -497,11 +499,13 @@ function cleanTestDirs() {
497499
jake.rmRf(localBaseline);
498500
}
499501

500-
// Clean the local Rwc baselines directory
502+
// Clean the local Rwc baselines directory
501503
if (fs.existsSync(localRwcBaseline)) {
502504
jake.rmRf(localRwcBaseline);
503505
}
504506

507+
jake.mkdirP(localRwcBaseline);
508+
jake.mkdirP(localTest262Baseline);
505509
jake.mkdirP(localBaseline);
506510
}
507511

@@ -513,8 +517,8 @@ function writeTestConfigFile(tests, testConfigFile) {
513517
}
514518

515519
function deleteTemporaryProjectOutput() {
516-
if (fs.existsSync(localBaseline + "projectOutput/")) {
517-
jake.rmRf(localBaseline + "projectOutput/");
520+
if (fs.existsSync(path.join(localBaseline, "projectOutput/"))) {
521+
jake.rmRf(path.join(localBaseline, "projectOutput/"));
518522
}
519523
}
520524

Diff for: src/harness/harness.ts

+20-9
Original file line numberDiff line numberDiff line change
@@ -1569,21 +1569,32 @@ module Harness {
15691569
export interface BaselineOptions {
15701570
LineEndingSensitive?: boolean;
15711571
Subfolder?: string;
1572+
Baselinefolder?: string;
15721573
}
15731574

1574-
export function localPath(fileName: string, subfolder?: string) {
1575-
return baselinePath(fileName, 'local', subfolder);
1575+
export function localPath(fileName: string, baselineFolder?: string, subfolder?: string) {
1576+
if (baselineFolder === undefined) {
1577+
return baselinePath(fileName, 'local', 'tests/baselines', subfolder);
1578+
}
1579+
else {
1580+
return baselinePath(fileName, 'local', baselineFolder, subfolder);
1581+
}
15761582
}
15771583

1578-
function referencePath(fileName: string, subfolder?: string) {
1579-
return baselinePath(fileName, 'reference', subfolder);
1584+
function referencePath(fileName: string, baselineFolder?: string, subfolder?: string) {
1585+
if (baselineFolder === undefined) {
1586+
return baselinePath(fileName, 'reference', 'tests/baselines', subfolder);
1587+
}
1588+
else {
1589+
return baselinePath(fileName, 'reference', baselineFolder, subfolder);
1590+
}
15801591
}
15811592

1582-
function baselinePath(fileName: string, type: string, subfolder?: string) {
1593+
function baselinePath(fileName: string, type: string, baselineFolder: string, subfolder?: string) {
15831594
if (subfolder !== undefined) {
1584-
return Harness.userSpecifiedroot + 'tests/baselines/' + subfolder + '/' + type + '/' + fileName;
1595+
return Harness.userSpecifiedroot + baselineFolder + '/' + subfolder + '/' + type + '/' + fileName;
15851596
} else {
1586-
return Harness.userSpecifiedroot + 'tests/baselines/' + type + '/' + fileName;
1597+
return Harness.userSpecifiedroot + baselineFolder + '/' + type + '/' + fileName;
15871598
}
15881599
}
15891600

@@ -1637,7 +1648,7 @@ module Harness {
16371648
return;
16381649
}
16391650

1640-
var refFilename = referencePath(relativeFilename, opts && opts.Subfolder);
1651+
var refFilename = referencePath(relativeFilename, opts && opts.Baselinefolder, opts && opts.Subfolder);
16411652

16421653
if (actual === null) {
16431654
actual = '<no content>';
@@ -1675,7 +1686,7 @@ module Harness {
16751686
opts?: BaselineOptions): void {
16761687

16771688
var actual = <string>undefined;
1678-
var actualFilename = localPath(relativeFilename, opts && opts.Subfolder);
1689+
var actualFilename = localPath(relativeFilename, opts && opts.Baselinefolder, opts && opts.Subfolder);
16791690

16801691
if (runImmediately) {
16811692
actual = generateActual(actualFilename, generateContent);

Diff for: src/harness/rwcRunner.ts

+5-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@ module RWC {
2626
var otherFiles: { unitName: string; content: string; }[] = [];
2727
var compilerResult: Harness.Compiler.CompilerResult;
2828
var compilerOptions: ts.CompilerOptions;
29-
var baselineOpts: Harness.Baseline.BaselineOptions = { Subfolder: 'rwc' };
29+
var baselineOpts: Harness.Baseline.BaselineOptions = {
30+
Subfolder: 'rwc',
31+
Baselinefolder: 'internal/baselines'
32+
};
3033
var baseName = /(.*)\/(.*).json/.exec(ts.normalizeSlashes(jsonPath))[2];
3134
var currentDirectory: string;
3235

@@ -170,7 +173,7 @@ module RWC {
170173
}
171174

172175
class RWCRunner extends RunnerBase {
173-
private static sourcePath = "tests/cases/rwc/";
176+
private static sourcePath = "internal/cases/rwc/";
174177

175178
/** Setup the runner's tests so that they are ready to be executed by the harness
176179
* The first test should be a describe/it block that sets up the harness's compiler instance appropriately

Diff for: src/harness/test262Runner.ts

+5-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
/// <reference path='syntacticCleaner.ts' />
44

55
class Test262BaselineRunner extends RunnerBase {
6-
private static basePath = 'tests/cases/test262';
6+
private static basePath = 'internal/cases/test262';
77
private static helpersFilePath = 'tests/cases/test262-harness/helpers.d.ts';
88
private static helperFile = {
99
unitName: Test262BaselineRunner.helpersFilePath,
@@ -15,7 +15,10 @@ class Test262BaselineRunner extends RunnerBase {
1515
target: ts.ScriptTarget.Latest,
1616
module: ts.ModuleKind.CommonJS
1717
};
18-
private static baselineOptions: Harness.Baseline.BaselineOptions = { Subfolder: 'test262' };
18+
private static baselineOptions: Harness.Baseline.BaselineOptions = {
19+
Subfolder: 'test262',
20+
Baselinefolder: 'internal/baselines'
21+
};
1922

2023
private static getTestFilePath(filename: string): string {
2124
return Test262BaselineRunner.basePath + "/" + filename;

0 commit comments

Comments
 (0)