Skip to content

Commit 7817fbf

Browse files
sheetalkamatsheetalkamat
committed
No need to check for file existence before reading the d.ts file
1 parent c8327da commit 7817fbf

File tree

137 files changed

+190
-524
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

137 files changed

+190
-524
lines changed

Diff for: ‎src/compiler/tsbuildPublic.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -970,9 +970,8 @@ namespace ts {
970970
let priorChangeTime: Date | undefined;
971971
if (!anyDtsChanged && isDeclarationFileName(name)) {
972972
// Check for unchanged .d.ts files
973-
const modifiedTime = getModifiedTime(host, name);
974-
if (modifiedTime !== missingFileModifiedTime && state.readFileWithCache(name) === text) {
975-
priorChangeTime = modifiedTime;
973+
if (state.readFileWithCache(name) === text) {
974+
priorChangeTime = getModifiedTime(host, name);
976975
}
977976
else {
978977
resultFlags &= ~BuildResultFlags.DeclarationOutputUnchanged;

Diff for: ‎tests/baselines/reference/tsbuild/amdModulesWithOut/modules-and-globals-mixed-in-amd.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,9 @@ getModifiedTime:: {
8989
"/src/lib/file2.ts": 1,
9090
"/src/lib/global.ts": 1,
9191
"/src/lib/module.js": 1,
92-
"/src/lib/module.d.ts": 1,
9392
"/src/app/file3.ts": 1,
9493
"/src/app/file4.ts": 1,
95-
"/src/app/module.js": 1,
96-
"/src/app/module.d.ts": 1
94+
"/src/app/module.js": 1
9795
}
9896

9997
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/amdModulesWithOut/multiple-emitHelpers-in-all-projects.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -101,11 +101,9 @@ getModifiedTime:: {
101101
"/src/lib/file2.ts": 1,
102102
"/src/lib/global.ts": 1,
103103
"/src/lib/module.js": 1,
104-
"/src/lib/module.d.ts": 1,
105104
"/src/app/file3.ts": 1,
106105
"/src/app/file4.ts": 1,
107-
"/src/app/module.js": 1,
108-
"/src/app/module.d.ts": 1
106+
"/src/app/module.js": 1
109107
}
110108

111109
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/amdModulesWithOut/multiple-prologues-in-all-projects.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,9 @@ getModifiedTime:: {
9494
"/src/lib/file2.ts": 1,
9595
"/src/lib/global.ts": 1,
9696
"/src/lib/module.js": 1,
97-
"/src/lib/module.d.ts": 1,
9897
"/src/app/file3.ts": 1,
9998
"/src/app/file4.ts": 1,
100-
"/src/app/module.js": 1,
101-
"/src/app/module.d.ts": 1
99+
"/src/app/module.js": 1
102100
}
103101

104102
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/amdModulesWithOut/shebang-in-all-projects.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,9 @@ getModifiedTime:: {
9292
"/src/lib/file2.ts": 1,
9393
"/src/lib/global.ts": 1,
9494
"/src/lib/module.js": 1,
95-
"/src/lib/module.d.ts": 1,
9695
"/src/app/file3.ts": 1,
9796
"/src/app/file4.ts": 1,
98-
"/src/app/module.js": 1,
99-
"/src/app/module.d.ts": 1
97+
"/src/app/module.js": 1
10098
}
10199

102100
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/amdModulesWithOut/stripInternal.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -115,11 +115,9 @@ getModifiedTime:: {
115115
"/src/lib/file2.ts": 1,
116116
"/src/lib/global.ts": 1,
117117
"/src/lib/module.js": 1,
118-
"/src/lib/module.d.ts": 1,
119118
"/src/app/file3.ts": 1,
120119
"/src/app/file4.ts": 1,
121-
"/src/app/module.js": 1,
122-
"/src/app/module.d.ts": 1
120+
"/src/app/module.js": 1
123121
}
124122

125123
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/amdModulesWithOut/triple-slash-refs-in-all-projects.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,10 @@ getModifiedTime:: {
100100
"/src/lib/global.ts": 1,
101101
"/src/lib/tripleRef.d.ts": 1,
102102
"/src/lib/module.js": 1,
103-
"/src/lib/module.d.ts": 1,
104103
"/src/app/file3.ts": 1,
105104
"/src/app/file4.ts": 1,
106105
"/src/app/tripleRef.d.ts": 1,
107-
"/src/app/module.js": 1,
108-
"/src/app/module.d.ts": 1
106+
"/src/app/module.js": 1
109107
}
110108

111109
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/amdModulesWithOut/when-the-module-resolution-finds-original-source-file.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,9 @@ getModifiedTime:: {
8989
"/src/lib/file2.ts": 1,
9090
"/src/lib/global.ts": 1,
9191
"/src/module.js": 1,
92-
"/src/module.d.ts": 1,
9392
"/src/app/file3.ts": 1,
9493
"/src/app/file4.ts": 1,
95-
"/src/app/module.js": 1,
96-
"/src/app/module.d.ts": 1
94+
"/src/app/module.js": 1
9795
}
9896

9997
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/configFileErrors/reports-syntax-errors-in-config-file.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -194,8 +194,7 @@ exitCode:: ExitStatus.Success
194194
getModifiedTime:: {
195195
"/src/a.ts": 1,
196196
"/src/b.ts": 1,
197-
"/src/a.js": 1,
198-
"/src/a.d.ts": 1
197+
"/src/a.js": 1
199198
}
200199

201200
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/configFileExtends/when-building-project-uses-reference-and-both-extend-config-with-include.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,8 @@ getModifiedTime:: {
6363
"/src/shared/index.ts": 1,
6464
"/src/shared/typings-base/globals.d.ts": 2,
6565
"/src/target-tsc-build/shared/index.js": 1,
66-
"/src/target-tsc-build/shared/index.d.ts": 1,
6766
"/src/webpack/index.ts": 1,
68-
"/src/target-tsc-build/webpack/index.js": 1,
69-
"/src/target-tsc-build/webpack/index.d.ts": 1
67+
"/src/target-tsc-build/webpack/index.js": 1
7068
}
7169

7270
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/configFileExtends/when-building-solution-with-projects-extends-config-with-include.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,8 @@ getModifiedTime:: {
6464
"/src/shared/index.ts": 1,
6565
"/src/shared/typings-base/globals.d.ts": 2,
6666
"/src/target-tsc-build/shared/index.js": 1,
67-
"/src/target-tsc-build/shared/index.d.ts": 1,
6867
"/src/webpack/index.ts": 1,
69-
"/src/target-tsc-build/webpack/index.js": 1,
70-
"/src/target-tsc-build/webpack/index.d.ts": 1
68+
"/src/target-tsc-build/webpack/index.js": 1
7169
}
7270

7371
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/containerOnlyReferenced/verify-that-subsequent-builds-after-initial-build-doesnt-build-anything.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -102,13 +102,10 @@ exitCode:: ExitStatus.Success
102102
getModifiedTime:: {
103103
"/src/src/folder/index.ts": 1,
104104
"/src/src/folder/index.js": 1,
105-
"/src/src/folder/index.d.ts": 1,
106105
"/src/src/folder2/index.ts": 1,
107106
"/src/src/folder2/index.js": 1,
108-
"/src/src/folder2/index.d.ts": 1,
109107
"/src/tests/index.ts": 1,
110-
"/src/tests/index.js": 1,
111-
"/src/tests/index.d.ts": 1
108+
"/src/tests/index.js": 1
112109
}
113110

114111
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/declarationEmit/when-declaration-file-is-referenced-through-triple-slash-but-uses-no-references.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,7 @@ getModifiedTime:: {
7272
"/src/solution/src/common/types.d.ts": 1,
7373
"/src/solution/src/subProject/index.ts": 1,
7474
"/src/solution/src/subProject2/index.ts": 1,
75-
"/src/solution/lib/src/common/nominal.js": 1,
76-
"/src/solution/lib/src/common/nominal.d.ts": 1
75+
"/src/solution/lib/src/common/nominal.js": 1
7776
}
7877

7978
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/declarationEmit/when-declaration-file-is-referenced-through-triple-slash.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,10 @@ exitCode:: ExitStatus.Success
8282
getModifiedTime:: {
8383
"/src/solution/src/common/nominal.ts": 1,
8484
"/src/solution/lib/src/common/nominal.js": 1,
85-
"/src/solution/lib/src/common/nominal.d.ts": 1,
8685
"/src/solution/src/subProject/index.ts": 1,
8786
"/src/solution/lib/src/subProject/index.js": 1,
88-
"/src/solution/lib/src/subProject/index.d.ts": 1,
8987
"/src/solution/src/subProject2/index.ts": 1,
90-
"/src/solution/lib/src/subProject2/index.js": 1,
91-
"/src/solution/lib/src/subProject2/index.d.ts": 1
88+
"/src/solution/lib/src/subProject2/index.js": 1
9289
}
9390

9491
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/declarationEmit/when-declaration-file-used-inferred-type-from-referenced-project.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,8 @@ exitCode:: ExitStatus.Success
5959
getModifiedTime:: {
6060
"/src/packages/pkg1/src/index.ts": 1,
6161
"/src/packages/pkg1/lib/src/index.js": 1,
62-
"/src/packages/pkg1/lib/src/index.d.ts": 1,
6362
"/src/packages/pkg2/src/index.ts": 1,
64-
"/src/packages/pkg2/lib/src/index.js": 1,
65-
"/src/packages/pkg2/lib/src/index.d.ts": 1
63+
"/src/packages/pkg2/lib/src/index.js": 1
6664
}
6765

6866
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/demo/in-master-branch-with-everything-setup-correctly-and-reports-no-error.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -168,15 +168,12 @@ exitCode:: ExitStatus.Success
168168
getModifiedTime:: {
169169
"/src/core/utilities.ts": 1,
170170
"/src/lib/core/utilities.js": 1,
171-
"/src/lib/core/utilities.d.ts": 1,
172171
"/src/animals/animal.ts": 1,
173172
"/src/animals/dog.ts": 1,
174173
"/src/animals/index.ts": 1,
175174
"/src/lib/animals/animal.js": 1,
176-
"/src/lib/animals/animal.d.ts": 1,
177175
"/src/zoo/zoo.ts": 1,
178-
"/src/lib/zoo/zoo.js": 1,
179-
"/src/lib/zoo/zoo.d.ts": 1
176+
"/src/lib/zoo/zoo.js": 1
180177
}
181178

182179
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/emitDeclarationOnly/only-dts-output-in-circular-import-project-with-emitDeclarationOnly-and-declarationMap.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,7 @@ getModifiedTime:: {
8484
"/src/src/b.ts": 1,
8585
"/src/src/c.ts": 1,
8686
"/src/src/index.ts": 1,
87-
"/src/lib/a.d.ts": 1,
88-
"/src/lib/c.d.ts": 1
87+
"/src/lib/a.d.ts": 1
8988
}
9089

9190
setModifiedTime:: {}
@@ -281,7 +280,7 @@ getModifiedTime:: {
281280
"/src/src/b.ts": 1,
282281
"/src/src/c.ts": 1,
283282
"/src/src/index.ts": 1,
284-
"/src/lib/a.d.ts": 2,
283+
"/src/lib/a.d.ts": 1,
285284
"/src/lib/b.d.ts": 1,
286285
"/src/lib/c.d.ts": 1,
287286
"/src/lib/index.d.ts": 1

Diff for: ‎tests/baselines/reference/tsbuild/emitDeclarationOnly/only-dts-output-in-circular-import-project-with-emitDeclarationOnly.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,7 @@ getModifiedTime:: {
8484
"/src/src/b.ts": 1,
8585
"/src/src/c.ts": 1,
8686
"/src/src/index.ts": 1,
87-
"/src/lib/a.d.ts": 1,
88-
"/src/lib/c.d.ts": 1
87+
"/src/lib/a.d.ts": 1
8988
}
9089

9190
setModifiedTime:: {}
@@ -268,7 +267,7 @@ getModifiedTime:: {
268267
"/src/src/b.ts": 1,
269268
"/src/src/c.ts": 1,
270269
"/src/src/index.ts": 1,
271-
"/src/lib/a.d.ts": 2,
270+
"/src/lib/a.d.ts": 1,
272271
"/src/lib/b.d.ts": 1,
273272
"/src/lib/c.d.ts": 1,
274273
"/src/lib/index.d.ts": 1

Diff for: ‎tests/baselines/reference/tsbuild/emitDeclarationOnly/only-dts-output-in-non-circular-imports-project-with-emitDeclarationOnly.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ getModifiedTime:: {
7777
"/src/src/a.ts": 1,
7878
"/src/src/b.ts": 1,
7979
"/src/src/c.ts": 1,
80-
"/src/lib/a.d.ts": 2
80+
"/src/lib/a.d.ts": 1
8181
}
8282

8383
setModifiedTime:: {}
@@ -375,7 +375,7 @@ getModifiedTime:: {
375375
"/src/src/a.ts": 1,
376376
"/src/src/b.ts": 1,
377377
"/src/src/c.ts": 1,
378-
"/src/lib/a.d.ts": 2,
378+
"/src/lib/a.d.ts": 1,
379379
"/src/lib/b.d.ts": 1
380380
}
381381

Diff for: ‎tests/baselines/reference/tsbuild/emptyFiles/does-not-have-empty-files-diagnostic-when-files-is-empty-and-references-are-provided.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,7 @@ exitCode:: ExitStatus.Success
6565

6666
getModifiedTime:: {
6767
"/src/core/index.ts": 1,
68-
"/src/core/index.js": 1,
69-
"/src/core/index.d.ts": 1
68+
"/src/core/index.js": 1
7069
}
7170

7271
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/inferredTypeFromTransitiveModule/inferred-type-from-transitive-module-with-isolatedModules.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,7 @@ getModifiedTime:: {
8787
"/src/global.d.ts": 1,
8888
"/src/index.ts": 1,
8989
"/src/lazyIndex.ts": 1,
90-
"/src/obj/bar.js": 1,
91-
"/src/obj/bar.d.ts": 1
90+
"/src/obj/bar.js": 1
9291
}
9392

9493
setModifiedTime:: {}
@@ -300,7 +299,6 @@ getModifiedTime:: {
300299
"/src/lazyIndex.ts": 1,
301300
"/src/obj/bar.js": 1,
302301
"/src/obj/lazyIndex.d.ts": 1,
303-
"/src/obj/index.d.ts": 1,
304302
"/src/obj/bundling.d.ts": 1
305303
}
306304

@@ -467,7 +465,6 @@ getModifiedTime:: {
467465
"/src/lazyIndex.ts": 1,
468466
"/src/obj/bar.js": 1,
469467
"/src/obj/lazyIndex.d.ts": 1,
470-
"/src/obj/index.d.ts": 1,
471468
"/src/obj/bundling.d.ts": 1
472469
}
473470

Diff for: ‎tests/baselines/reference/tsbuild/inferredTypeFromTransitiveModule/inferred-type-from-transitive-module.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,7 @@ getModifiedTime:: {
8787
"/src/global.d.ts": 1,
8888
"/src/index.ts": 1,
8989
"/src/lazyIndex.ts": 1,
90-
"/src/obj/bar.js": 1,
91-
"/src/obj/bar.d.ts": 1
90+
"/src/obj/bar.js": 1
9291
}
9392

9493
setModifiedTime:: {}
@@ -299,7 +298,6 @@ getModifiedTime:: {
299298
"/src/index.ts": 1,
300299
"/src/lazyIndex.ts": 1,
301300
"/src/obj/bar.js": 1,
302-
"/src/obj/index.d.ts": 1,
303301
"/src/obj/bundling.d.ts": 1
304302
}
305303

@@ -465,7 +463,6 @@ getModifiedTime:: {
465463
"/src/index.ts": 1,
466464
"/src/lazyIndex.ts": 1,
467465
"/src/obj/bar.js": 1,
468-
"/src/obj/index.d.ts": 1,
469466
"/src/obj/bundling.d.ts": 1
470467
}
471468

Diff for: ‎tests/baselines/reference/tsbuild/inferredTypeFromTransitiveModule/reports-errors-in-files-affected-by-change-in-signature-with-isolatedModules.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,7 @@ getModifiedTime:: {
8989
"/src/global.d.ts": 1,
9090
"/src/index.ts": 1,
9191
"/src/lazyIndex.ts": 1,
92-
"/src/obj/bar.js": 1,
93-
"/src/obj/bar.d.ts": 1
92+
"/src/obj/bar.js": 1
9493
}
9594

9695
setModifiedTime:: {}
@@ -798,7 +797,6 @@ getModifiedTime:: {
798797
"/src/index.ts": 1,
799798
"/src/lazyIndex.ts": 1,
800799
"/src/obj/bar.js": 1,
801-
"/src/obj/bar.d.ts": 1,
802800
"/src/obj/bundling.d.ts": 1
803801
}
804802

Diff for: ‎tests/baselines/reference/tsbuild/javascriptProjectEmit/loads-js-based-projects-and-emits-them-correctly.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -120,13 +120,10 @@ exitCode:: ExitStatus.Success
120120
getModifiedTime:: {
121121
"/src/common/nominal.js": 1,
122122
"/lib/common/nominal.js": 1,
123-
"/lib/common/nominal.d.ts": 1,
124123
"/src/sub-project/index.js": 1,
125124
"/lib/sub-project/index.js": 1,
126-
"/lib/sub-project/index.d.ts": 1,
127125
"/src/sub-project-2/index.js": 1,
128-
"/lib/sub-project-2/index.js": 1,
129-
"/lib/sub-project-2/index.d.ts": 1
126+
"/lib/sub-project-2/index.js": 1
130127
}
131128

132129
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/javascriptProjectEmit/loads-js-based-projects-with-non-moved-json-files-and-emits-them-correctly.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -121,13 +121,10 @@ getModifiedTime:: {
121121
"/src/common/index.ts": 1,
122122
"/src/common/obj.json": 1,
123123
"/src/common/index.js": 1,
124-
"/src/common/index.d.ts": 1,
125124
"/src/sub-project/index.js": 1,
126125
"/out/sub-project/index.js": 1,
127-
"/out/sub-project/index.d.ts": 1,
128126
"/src/sub-project-2/index.js": 1,
129-
"/out/sub-project-2/index.js": 1,
130-
"/out/sub-project-2/index.d.ts": 1
127+
"/out/sub-project-2/index.js": 1
131128
}
132129

133130
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/javascriptProjectEmit/modifies-outfile-js-projects-and-concatenates-them-correctly.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -122,13 +122,10 @@ exitCode:: ExitStatus.Success
122122
getModifiedTime:: {
123123
"/src/common/nominal.js": 1,
124124
"/src/common/common.js": 1,
125-
"/src/common/common.d.ts": 1,
126125
"/src/sub-project/index.js": 1,
127126
"/src/sub-project/sub-project.js": 1,
128-
"/src/sub-project/sub-project.d.ts": 1,
129127
"/src/sub-project-2/index.js": 1,
130-
"/src/sub-project-2/sub-project-2.js": 1,
131-
"/src/sub-project-2/sub-project-2.d.ts": 1
128+
"/src/sub-project-2/sub-project-2.js": 1
132129
}
133130

134131
setModifiedTime:: {}

Diff for: ‎tests/baselines/reference/tsbuild/moduleResolution/resolves-specifier-in-output-declaration-file-from-referenced-project-correctly-with-preserveSymlinks.js

-1
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,6 @@ getModifiedTimes:: {
263263
"/user/username/projects/myproject/packages/pkg2/const.ts": 1,
264264
"/user/username/projects/myproject/packages/pkg2/index.ts": 1,
265265
"/user/username/projects/myproject/packages/pkg2/build/const.js": 1,
266-
"/user/username/projects/myproject/packages/pkg2/build/const.d.ts": 1,
267266
"/user/username/projects/myproject/packages/pkg1/index.ts": 1,
268267
"/user/username/projects/myproject/packages/pkg1/build/index.js": 1
269268
}

0 commit comments

Comments
 (0)