Emit '?' for optional parameter property in declaration file

ahejlsberg · ahejlsberg · commit a11f72f9ab5d · 2016-05-16T13:34:54.000-07:00
diff --git a/src/compiler/declarationEmitter.ts b/src/compiler/declarationEmitter.ts
@@ -1129,7 +1129,7 @@ namespace ts {
                     // what we want, namely the name expression enclosed in brackets.
                     writeTextOfNode(currentText, node.name);
                     // If optional property emit ?
-                    if ((node.kind === SyntaxKind.PropertyDeclaration || node.kind === SyntaxKind.PropertySignature) && hasQuestionToken(node)) {
+                    if ((node.kind === SyntaxKind.PropertyDeclaration || node.kind === SyntaxKind.PropertySignature || node.kind === SyntaxKind.Parameter) && hasQuestionToken(node)) {
                         write("?");
                     }
                     if ((node.kind === SyntaxKind.PropertyDeclaration || node.kind === SyntaxKind.PropertySignature) && node.parent.kind === SyntaxKind.TypeLiteral) {

Original file line number	Diff line number	Diff line change
`@@ -1129,7 +1129,7 @@ namespace ts {`
`1129`	`1129`	`// what we want, namely the name expression enclosed in brackets.`
`1130`	`1130`	`writeTextOfNode(currentText, node.name);`
`1131`	`1131`	`// If optional property emit ?`
`1132`		`- if ((node.kind === SyntaxKind.PropertyDeclaration \|\| node.kind === SyntaxKind.PropertySignature) && hasQuestionToken(node)) {`
	`1132`	`+ if ((node.kind === SyntaxKind.PropertyDeclaration \|\| node.kind === SyntaxKind.PropertySignature \|\| node.kind === SyntaxKind.Parameter) && hasQuestionToken(node)) {`
`1133`	`1133`	`write("?");`
`1134`	`1134`	`}`
`1135`	`1135`	`if ((node.kind === SyntaxKind.PropertyDeclaration \|\| node.kind === SyntaxKind.PropertySignature) && node.parent.kind === SyntaxKind.TypeLiteral) {`