Merge remote-tracking branch 'origin/main' into fix/property-with-context-sensitive-return-statement

Author: Andarist

.devcontainer/Dockerfile

@@ -4,4 +4,4 @@
 ARG VARIANT="14-buster"
 FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}
 
-RUN sudo -u node npm install -g gulp-cli
+RUN sudo -u node npm install -g hereby

.dockerignore

@@ -2,7 +2,7 @@ const fs = require("fs");
 const path = require("path");
 
 const rulesDir = path.join(__dirname, "scripts", "eslint", "rules");
-const ext = ".js";
+const ext = ".cjs";
 const ruleFiles = fs.readdirSync(rulesDir).filter((p) => p.endsWith(ext));
 
 module.exports = {

.eslintignore

@@ -1,8 +1,8 @@
 {
+    "root": true,
     "parser": "@typescript-eslint/parser",
     "parserOptions": {
         "warnOnUnsupportedTypeScriptVersion": false,
-        "ecmaVersion": 6,
         "sourceType": "module"
     },
     "env": {
@@ -11,22 +11,29 @@
         "es6": true
     },
     "plugins": [
-        "@typescript-eslint", "jsdoc", "no-null", "import", "eslint-plugin-local"
+        "@typescript-eslint", "no-null", "import", "eslint-plugin-local"
     ],
-    "overrides": [
-        // By default, the ESLint CLI only looks at .js files. But, it will also look at
-        // any files which are referenced in an override config. Most users of typescript-eslint
-        // get this behavior by default by extending a recommended typescript-eslint config, which 
-        // just so happens to override some core ESLint rules. We don't extend from any config, so
-        // explicitly reference TS files here so the CLI picks them up.
-        //
-        // ESLint in VS Code will lint any opened file (so long as it's not eslintignore'd), so
-        // that will work regardless of the below.
-        { "files": ["*.ts", "*.mts", "*.cts", "*.mjs", "*.cjs"] }
+    "ignorePatterns": [
+        "**/node_modules/**",
+        "/built/**",
+        "/tests/**",
+        "/lib/**",
+        "/src/lib/*.generated.d.ts",
+        "/scripts/**/*.js",
+        "/scripts/**/*.d.*",
+        "/internal/**",
+        "/coverage/**"
     ],
     "rules": {
+        "sort-imports": ["error", {
+            "ignoreCase": true,
+            "ignoreDeclarationSort": true,
+            "allowSeparatedGroups": true
+        }],
+
         "@typescript-eslint/adjacent-overload-signatures": "error",
         "@typescript-eslint/array-type": "error",
+        "@typescript-eslint/no-array-constructor": "error",
 
         "brace-style": "off",
         "@typescript-eslint/brace-style": ["error", "stroustrup", { "allowSingleLine": true }],
@@ -62,12 +69,14 @@
         "@typescript-eslint/prefer-for-of": "error",
         "@typescript-eslint/prefer-function-type": "error",
         "@typescript-eslint/prefer-namespace-keyword": "error",
+        "@typescript-eslint/prefer-as-const": "error",
 
         "quotes": "off",
         "@typescript-eslint/quotes": ["error", "double", { "avoidEscape": true, "allowTemplateLiterals": true }],
 
         "semi": "off",
         "@typescript-eslint/semi": "error",
+        "@typescript-eslint/no-extra-semi": "error",
 
         "space-before-function-paren": "off",
         "@typescript-eslint/space-before-function-paren": ["error", {
@@ -80,6 +89,8 @@
         "@typescript-eslint/type-annotation-spacing": "error",
         "@typescript-eslint/unified-signatures": "error",
 
+        "@typescript-eslint/no-extra-non-null-assertion": "error",
+
         // scripts/eslint/rules
         "local/object-literal-surrounding-space": "error",
         "local/no-type-assertion-whitespace": "error",
@@ -94,17 +105,14 @@
         "local/simple-indent": "error",
         "local/debug-assert": "error",
         "local/no-keywords": "error",
-        "local/one-namespace-per-file": "error",
+        "local/jsdoc-format": "error",
 
         // eslint-plugin-import
         "import/no-extraneous-dependencies": ["error", { "optionalDependencies": false }],
 
         // eslint-plugin-no-null
         "no-null/no-null": "error",
 
-        // eslint-plugin-jsdoc
-        "jsdoc/check-alignment": "error",
-
         // eslint
         "constructor-super": "error",
         "curly": ["error", "multi-line"],
@@ -143,6 +151,35 @@
         "quote-props": ["error", "consistent-as-needed"],
         "space-in-parens": "error",
         "unicode-bom": ["error", "never"],
-        "use-isnan": "error"
-    }
+        "use-isnan": "error",
+        "no-prototype-builtins": "error",
+        "no-self-assign": "error",
+        "no-dupe-else-if": "error"
+    },
+    "overrides": [
+        // By default, the ESLint CLI only looks at .js files. But, it will also look at
+        // any files which are referenced in an override config. Most users of typescript-eslint
+        // get this behavior by default by extending a recommended typescript-eslint config, which 
+        // just so happens to override some core ESLint rules. We don't extend from any config, so
+        // explicitly reference TS files here so the CLI picks them up.
+        //
+        // ESLint in VS Code will lint any opened file (so long as it's not eslintignore'd), so
+        // that will work regardless of the below.
+        //
+        // The same applies to mjs files; ESLint appears to not scan those either.
+        { "files": ["*.ts", "*.mts", "*.cts", "*.mjs", "*.cjs"] },
+        {
+            "files": ["*.mjs", "*.mts"],
+            "rules": {
+                // These globals don't exist outside of CJS files.
+                "no-restricted-globals": ["error",
+                    { "name": "__filename" },
+                    { "name": "__dirname" },
+                    { "name": "require" },
+                    { "name": "module" },
+                    { "name": "exports" }
+                ]
+            }
+        }
+    ]
 }

.eslintplugin.js

@@ -0,0 +1,8 @@
+# Generated module conversion step - inlineImports
+07758c08ab72481885e662c98d67a0e3a071b032
+# Generated module conversion step - stripNamespaces
+b6c053882696af8ddd94a600429f30584d303d7f
+# Generated module conversion step - explicitify
+9a0b85ce2a3f85f498ab2c05474b4c0b96b111c9
+# Generated module conversion step - unindent
+94724a8c2e68a4c7e267072ca79971f317c45e4a

.eslintrc.json

@@ -1,4 +1,8 @@
 name : CodeQL Configuration
 
 paths:
-  - './src' 
+  - src
+  - scripts
+  - Herebyfile.mjs
+paths-ignore:
+  - src/lib