Fix property name to include PrivateNames

Joey Watts · Joey Watts · commit c24df578e13c · 2019-06-26T13:57:43.000-04:00
Signed-off-by: Joey Watts &lt;jwatts43@bloomberg.net&gt;
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -10105,7 +10105,7 @@ namespace ts {
             return false;
         }
 
-        function getPropertyNameFromIndex(indexType: Type, accessNode: StringLiteral | Identifier | ObjectBindingPattern | ArrayBindingPattern | ComputedPropertyName | NumericLiteral | IndexedAccessTypeNode | ElementAccessExpression | SyntheticExpression | undefined) {
+        function getPropertyNameFromIndex(indexType: Type, accessNode: StringLiteral | Identifier | ObjectBindingPattern | ArrayBindingPattern | ComputedPropertyName | NumericLiteral | IndexedAccessTypeNode | ElementAccessExpression | SyntheticExpression | PrivateName | undefined) {
             const accessExpression = accessNode && accessNode.kind === SyntaxKind.ElementAccessExpression ? accessNode : undefined;
             return isTypeUsableAsPropertyName(indexType) ?
                 getPropertyNameFromType(indexType) :
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -6277,7 +6277,8 @@ namespace ts {
         return kind === SyntaxKind.Identifier
             || kind === SyntaxKind.StringLiteral
             || kind === SyntaxKind.NumericLiteral
-            || kind === SyntaxKind.ComputedPropertyName;
+            || kind === SyntaxKind.ComputedPropertyName
+            || kind === SyntaxKind.PrivateName;
     }
 
     export function isBindingName(node: Node): node is BindingName {

Original file line number	Diff line number	Diff line change
`@@ -10105,7 +10105,7 @@ namespace ts {`
`10105`	`10105`	`return false;`
`10106`	`10106`	`}`
`10107`	`10107`
`10108`		`- function getPropertyNameFromIndex(indexType: Type, accessNode: StringLiteral \| Identifier \| ObjectBindingPattern \| ArrayBindingPattern \| ComputedPropertyName \| NumericLiteral \| IndexedAccessTypeNode \| ElementAccessExpression \| SyntheticExpression \| undefined) {`
	`10108`	`+ function getPropertyNameFromIndex(indexType: Type, accessNode: StringLiteral \| Identifier \| ObjectBindingPattern \| ArrayBindingPattern \| ComputedPropertyName \| NumericLiteral \| IndexedAccessTypeNode \| ElementAccessExpression \| SyntheticExpression \| PrivateName \| undefined) {`
`10109`	`10109`	`const accessExpression = accessNode && accessNode.kind === SyntaxKind.ElementAccessExpression ? accessNode : undefined;`
`10110`	`10110`	`return isTypeUsableAsPropertyName(indexType) ?`
`10111`	`10111`	`getPropertyNameFromType(indexType) :`
Original file line number	Diff line number	Diff line change
`@@ -6277,7 +6277,8 @@ namespace ts {`
`6277`	`6277`	`return kind === SyntaxKind.Identifier`
`6278`	`6278`	`\|\| kind === SyntaxKind.StringLiteral`
`6279`	`6279`	`\|\| kind === SyntaxKind.NumericLiteral`
`6280`		`- \|\| kind === SyntaxKind.ComputedPropertyName;`
	`6280`	`+ \|\| kind === SyntaxKind.ComputedPropertyName`
	`6281`	`+ \|\| kind === SyntaxKind.PrivateName;`
`6281`	`6282`	`}`
`6282`	`6283`
`6283`	`6284`	`export function isBindingName(node: Node): node is BindingName {`