Skip to content

Go-to-Implementation & class names #11504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
angelozerr opened this issue Oct 10, 2016 · 4 comments
Open

Go-to-Implementation & class names #11504

angelozerr opened this issue Oct 10, 2016 · 4 comments
Labels
API Relates to the public API for TypeScript Help Wanted You can do this Suggestion An idea for TypeScript
Milestone

Comments

@angelozerr
Copy link

angelozerr commented Oct 10, 2016

I have started to implement "Go-to-Implementation" by consumming tsserver "implementation" command inside Eclipse to do the same thing than Java:

See #8268

The tsserver "implementation" command returns list of FileSpan (file, location)) but not the text of the implemented class ("MyServiceA", "MyServiceB"). If you see the below screenshost, it should be really cool to have too the name of the classes which implement the interface.

Many thanks

@mhegazy mhegazy added Suggestion An idea for TypeScript Help Wanted You can do this API Relates to the public API for TypeScript labels Oct 10, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Oct 10, 2016

@angelozerr a PR would be appreciated.

@angelozerr
Copy link
Author

@mhegazy I will try to do that if I find time. Thanks for your answer!

@angelozerr
Copy link
Author

@Andy-MS is there any chance that you could fix this issue. It should be fantastic that "implementation" command will return the same information like "navtree":

  • name: string;

    • kind: string;
    • kindModifiers: string;

    In other words:

export interface ImplementationResponse extends Response {
        body?: ImplementationResponseItem[];
}

export interface ImplementationResponseItem extends FileSpan {

        /**
          * The symbol's name.
          */
        name: string;

        /**
          * The symbol's kind (such as 'className' or 'parameterName').
          */
        kind: string;

       /**
          * Optional modifiers for the kind (such as 'public').
          */
        kindModifiers?: string;
}

@angelozerr
Copy link
Author

@mhegazy @Andy-MS here a demo with "Open Implementation" inside Eclipse:

openimplementationdemo

As you can see, I have displayed in the popup dialog the file name which is not very helpful in this case. Hope in the future you could add symbol name. Thanks!

@mhegazy mhegazy added this to the Community milestone Nov 23, 2017
@RyanCavanaugh RyanCavanaugh modified the milestones: Community, Backlog Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Relates to the public API for TypeScript Help Wanted You can do this Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

3 participants