-
Notifications
You must be signed in to change notification settings - Fork 12.8k
#182 for dom.generated.d.ts? #15348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Or can we please just convert them to classes? |
Classes wouldn't allow you to add new construct signatures - only new static members. |
Ah yes, you're right. |
I would not want to add a static interface for every DOM interface, that is a lot of global scope pollution. If you are really blocked, just copy lib.d.ts change the declaration, and use it until the issue is fixed. |
I agree, but then what do you think about class-ifying them? It will still not allow adding constructor signatures but at least will do for other members. |
I think we should add classes regardless. that is covered by #574 |
TypeScript Version: 2.2.1 / nightly (2.2.0-dev.201xxxxx)
Code
(Covered by #15338)
Expected behavior:
#182 should be applied to DOM types
Actual behavior:
No way to add a new overload signature before a PR to fix
The text was updated successfully, but these errors were encountered: