Skip to content

TS Server crashes once TS file is open #15716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjbvz opened this issue May 10, 2017 · 8 comments
Closed

TS Server crashes once TS file is open #15716

mjbvz opened this issue May 10, 2017 · 8 comments
Labels
Bug A bug in TypeScript VS Code Tracked There is a VS Code equivalent to this issue

Comments

@mjbvz
Copy link
Contributor

mjbvz commented May 10, 2017

From @aminpaks on May 9, 2017 11:21

  • VSCode Version: 1.12.1
  • OS Version: macOS 10.12.4 (16E195)

The project is private so I can't share the code or steps to reproduce it though I'm going to provide some logs, hopefully will be enough. If you need something else please ask.
The file that I open is about 1100 lines and it's a pure typescript file that is importing some of lodash, d3 and angular v4.
As soon as I open this file TS Server crashes and nothing will work anymore! TS Server restarts but it gets stuck at binding forever, and the only way to get Code to work is to restart.
This issue started right after updating to 1.12

Here is the TS Server log file
Here is the ChromeDevTools console

Copied from original issue: microsoft/vscode#26299

@mjbvz
Copy link
Contributor Author

mjbvz commented May 10, 2017

From @aminpaks on May 9, 2017 17:43

So apparently the issue is with Typescript v2.3.x, it works with v2.2.x
Should I inform Typescript team, or you guys can move this?

@mjbvz
Copy link
Contributor Author

mjbvz commented May 10, 2017

Moving over to TypeScript repo since it sounds like the issue only happens when TypeScript 2.3 is used. I don't see anything suspicious in the log file or the the developer tools screenshot

@aminpaks Can you try setting "typescript.tsserver.trace": "verbose" in VSCode and reproducing the issue. Then open the output panel and share the output from the TypeScript output section. This may provide some additional clues to what is going wrong

Also does this happen for all projects, or just the one project you are working in?

@aminpaks
Copy link
Contributor

aminpaks commented May 10, 2017

Sure Matt,
This happens only on a few files of one specific project so far.

Here is the TS Server trace log

@mhegazy mhegazy assigned ghost May 10, 2017
@mhegazy mhegazy added the Bug A bug in TypeScript label May 10, 2017
@mhegazy mhegazy added this to the TypeScript 2.4 milestone May 10, 2017
@westonpace
Copy link

This seems very similar to #15028 . I've recorded my observations there but it's about the same, crashes as soon as I open (actually it won't crash until I try and resolve a particular symbol in my file), doesn't occur on 2.2 but does on 2.3, etc.

@ghost
Copy link

ghost commented May 12, 2017

This looks similar to #15688. In both cases:

  • A request is sent.
  • Semantic diagnostics are sent back.
  • The original request is never answered.
  • A bunch of other requests are immediately canceled.

@ghost
Copy link

ghost commented Jul 12, 2017

Hi @aminpaks, @westonpace, we're trying to confirm if this can still happen in typescript@next. We can't get much from the server logs, since all they show is that TypeScript is failing somewhere inside quickInfo, presumably somewhere inside the checker. Could either of you find a scenario that reproduces this that you're willing to share? If you know the symbol whose hover causes the problem, you should be able to extract out just the parts of your related to that symbol to reproduce the error.

@aminpaks
Copy link
Contributor

aminpaks commented Jul 12, 2017

@Andy-MS I'd really like to help, and I tried to reproduce it with typescript@next but no luck.
I'll keep you posted if I had a chance to catch it.

@mhegazy mhegazy added the VS Code Tracked There is a VS Code equivalent to this issue label Aug 16, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Aug 16, 2017

closing for now. please reopen if you see the issue again.

@mhegazy mhegazy closed this as completed Aug 16, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

No branches or pull requests

4 participants