Skip to content

breaking change in tsserver public API in ts2.5 #17894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anstarovoyt opened this issue Aug 18, 2017 · 2 comments
Closed

breaking change in tsserver public API in ts2.5 #17894

anstarovoyt opened this issue Aug 18, 2017 · 2 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Milestone
TypeScript 2.5.2

Comments

@anstarovoyt
Copy link

Hi. I reported several similar issues before. We (WebStorm) use tsserver (in fact tsserverlibrary) integration. This commit broke our integration because we have to implement the logger interface manually.
Can you provide a default logger implementation for avoiding such problems in future?
//cc @Andy-MS
@mhegazy mhegazy added the Bug A bug in TypeScript label Aug 18, 2017
@mhegazy mhegazy added this to the TypeScript 2.5.1 milestone Aug 18, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Aug 18, 2017

We will get the change reverted, and an @insiders drop released later today.

@mhegazy mhegazy assigned ghost Aug 18, 2017
@ghost ghost mentioned this issue Aug 18, 2017
Merged
@ghost ghost closed this as completed in #17899 Aug 18, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Aug 18, 2017

typescript@rc should now point to [email protected] which has a revert to this change. sorry for the hassle.

@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Aug 24, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 2.5.2
Development

No branches or pull requests
2 participants
@anstarovoyt @mhegazy