New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick fix at await to make current function async #21034

Closed

jwbay opened this issue Jan 5, 2018 · 3 comments · Fixed by #21069

Labels

Domain: Quick Fixes Fixed Good First Issue Help Wanted Suggestion

Milestone

Contributor

jwbay commented Jan 5, 2018

TypeScript Version: 2.7.0-dev.201xxxxx

Code

function foo() {
  await/*1*/ bar();
}

Expected behavior:
At 1, offers a code action that converts the innermost function to async:

async function foo() {
  await bar();
}

Actual behavior:
Error at 1 with no quick fix offered

mhegazy added Suggestion Good First Issue Help Wanted labels

Contributor

mhegazy commented Jan 6, 2018

A PR for adding the new quick fix would be appreciated. should be a simple one to add.

mhegazy added the Domain: Quick Fixes label

mhegazy added this to the Community milestone

Contributor

srolel commented Jan 8, 2018

I'd like to work on this, I think I have all I need (taking examples from the files in src/services/codefixes).

srolel mentioned this issue

add fixAwaitInSyncFunction code fix #21069

Merged

mhegazy closed this as completed in #21069

mhegazy added the Fixed label

mhegazy modified the milestones: Community, TypeScript 2.7

Contributor

mhegazy commented Jan 10, 2018

thanks @mohsen1 !

microsoft locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.