Skip to content

ES6 imports not emitted in declaration files #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csnover opened this issue Mar 6, 2015 · 5 comments
Closed

ES6 imports not emitted in declaration files #2220

csnover opened this issue Mar 6, 2015 · 5 comments
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@csnover
Copy link
Contributor

csnover commented Mar 6, 2015

Source:

// foo.ts
var foo = {};
export = foo;
// bar.ts
import foo from './foo';
export = foo;

Command line: tsc -m amd -t es5 -d foo.ts bar.ts

Expected output of bar.d.ts:

import foo from './foo';
export = foo;

Actual output of bar.d.ts:

export = foo;

Legacy import foo = require('./foo') still is emitted.

Version: Arnavion/typescript-github#2015-03-05-b784a4212aeb5a4e42a598a8613a0538ac241123

@csnover
Copy link
Contributor Author

csnover commented Mar 6, 2015

Maybe this is fixed already by #2197, I haven’t tried merging that and testing. There are a lot of ES6 module related tickets thrown around that aren‘t being referenced in commits so it is hard for me to know what is going on with its progress.

@csnover
Copy link
Contributor Author

csnover commented Mar 6, 2015

Er, no, just merged and tested, it appears to be not resolved by #2197.

@csnover
Copy link
Contributor Author

csnover commented Mar 6, 2015

This is fixed when #2139 lands.

@danquirk danquirk added the Bug A bug in TypeScript label Mar 10, 2015
@danquirk
Copy link
Member

Going to leave this open to ensure it gets checked as fixed when that work is checked in.

@mhegazy mhegazy added this to the TypeScript 1.5 milestone Mar 11, 2015
@mhegazy mhegazy self-assigned this Mar 11, 2015
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Mar 18, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Mar 18, 2015

Fixed by #2139

@mhegazy mhegazy closed this as completed Mar 18, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

3 participants