Skip to content

'Change spelling' quick-fix should probably be the highest priority fix #23258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanielRosenwasser opened this issue Apr 8, 2018 · 1 comment
Labels
Bug A bug in TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. Fixed A PR has been merged for this issue

Comments

@DanielRosenwasser
Copy link
Member

class Foo {
    props

    rendar() {
        this.porps
    }
}

Expected: Change spelling to 'props' should be the first item in the list.
Actual:

image

@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. labels Apr 8, 2018
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 2.9 milestone Apr 8, 2018
@krryan
Copy link

krryan commented Apr 9, 2018

I agree that it should have priority over declaring a new property (named or index signature).

But it definitely should not have priority over importing something that the name matches. I have seen 'change spelling' as an option in situations where I'm referencing some existing export, looking to use the 'import' quick-fix. That should have still-higher priority; changing the spelling to some similarly-named deal is not what is likely wanted in the situation where the "spelling error" matches some other export.

@ghost ghost added the Fixed A PR has been merged for this issue label Apr 9, 2018
@ghost ghost closed this as completed in #23268 Apr 9, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

2 participants