Skip to content

strictNullChecks and the compiler's code #23404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikeee opened this issue Apr 13, 2018 · 4 comments
Closed

strictNullChecks and the compiler's code #23404

nikeee opened this issue Apr 13, 2018 · 4 comments
Labels
Duplicate An existing issue was already created

Comments

@nikeee
Copy link
Contributor

nikeee commented Apr 13, 2018

Currently, the compiler seems to be compiled without the strictNullChecks flag. Is there any plan to update (parts of) the code base to compile with this flag?

I know there are some parts that require a large amount of rewirting just to satisfy this flag. However, some APIs could easily be changed. Are small, partial strictNullCheck-enhancements something that would be accepted for merges?

I'm currently looking at something like pasers#visitNode(s) and scanner.setText()

@RyanCavanaugh
Copy link
Member

image

@RyanCavanaugh
Copy link
Member

We're hoping to merge that PR quite soon

@DanielRosenwasser DanielRosenwasser added the Duplicate An existing issue was already created label Apr 13, 2018
@DanielRosenwasser
Copy link
Member

Duplicate of #9432.

@nikeee
Copy link
Contributor Author

nikeee commented Apr 13, 2018

Thanks! I searched only the issues, not the PRs. The Issues are filled with stuff of strictNullChecks.

@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

3 participants