Skip to content

codeActionsOnSave removing json file #23903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjbvz opened this issue May 4, 2018 · 2 comments
Closed

codeActionsOnSave removing json file #23903

mjbvz opened this issue May 4, 2018 · 2 comments
Labels
Needs More Info The issue still hasn't been fully clarified

Comments

@mjbvz
Copy link
Contributor

mjbvz commented May 4, 2018

From @eddiemoore on May 3, 2018 8:25

Issue Type: Bug

Using the new organizeImports will remove a json file that was actually used in the code. Using Typescript.

import introspectionQueryResultData from './fragmentTypes.json'

// later
const fragmentMatcher = new IntrospectionFragmentMatcher({
  introspectionQueryResultData,
})

After running the action on save it removes the import statement.

VS Code version: Code - Insiders 1.23.0-insider (a656d397e424173c86f32703e0c0293bd8084da0, 2018-05-03T00:02:37.895Z)
OS version: Darwin x64 17.5.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 2
Memory (System) 16.00GB (0.57GB free)
Process Argv /Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_2388551
Screen Reader no
VM 0%
Extensions (16)
Extension Author (truncated) Version
vscode-docker Pet 0.0.26
vscode-eslint dba 1.4.8
tslint eg2 1.0.28
vscode-npm-script eg2 0.3.4
prettier-vscode esb 1.3.1
auto-close-tag for 0.5.6
auto-rename-tag for 0.0.15
vscode-styled-components jpo 0.0.18
graphql-for-vscode kum 1.10.2
debugger-for-chrome msj 4.3.0
vscode-icons rob 7.23.0
language-stylus sys 1.9.2
gitblame wad 2.4.2
vscode-todo-highlight way 0.5.12
vscode-import-cost wix 2.6.2
JavaScriptSnippets xab 1.6.0

(1 theme extensions excluded)

Copied from original issue: microsoft/vscode#49104

@mjbvz mjbvz self-assigned this May 4, 2018
@mjbvz mjbvz removed their assignment May 4, 2018
@mhegazy
Copy link
Contributor

mhegazy commented May 4, 2018

I am unable to reproduce this locally on latest VSCode. Can you share more context, possibly the complete file/project where you see this behavior or more details about how to setup a repro for this issue.

@mhegazy mhegazy added the Needs More Info The issue still hasn't been fully clarified label May 4, 2018
@eddiemoore
Copy link

It seems in the latest release 1.24.0-insider it has fixed this issue.

@mhegazy mhegazy closed this as completed May 7, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs More Info The issue still hasn't been fully clarified
Projects
None yet
Development

No branches or pull requests

3 participants