Skip to content

Rename Symbol is messing up object literal shorthand #27189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanielRosenwasser opened this issue Sep 18, 2018 · 2 comments
Closed

Rename Symbol is messing up object literal shorthand #27189

DanielRosenwasser opened this issue Sep 18, 2018 · 2 comments
Labels
Duplicate An existing issue was already created

Comments

@DanielRosenwasser
Copy link
Member

From @lordnox on August 30, 2018 15:37

Example Code:

interface ITest {
  x: number
}
const createTest = (): ITest => {
  const x = Math.random()
  return {
    x,
  }
}

When trying to rename const x to const rnd the code will become:

interface ITest {
  x: number
}
const createTest = (): ITest => {
  const rnd = Math.random()
  return {
    rnd,
  }
}

This does kind of do the right thing, but changes the return type of the function and should actually become:

interface ITest {
  x: number
}
const createTest = (): ITest => {
  const rnd = Math.random()
  return {
    x: rnd,
  }
}

Copied from original issue: microsoft/TypeScript-Sublime-Plugin#673

@ghost
Copy link

ghost commented Sep 18, 2018

Duplicate of #12007

@ghost ghost marked this as a duplicate of #12007 Sep 18, 2018
@ghost ghost added the Duplicate An existing issue was already created label Sep 18, 2018
@typescript-bot
Copy link
Collaborator

This issue has been marked as a 'Duplicate' and has seen no recent activity. It has been automatically closed for house-keeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

2 participants